Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ResultSet.getObject(int/String, Class) #304

Merged
merged 1 commit into from
Jul 24, 2017
Merged

Implement ResultSet.getObject(int/String, Class) #304

merged 1 commit into from
Jul 24, 2017

Conversation

marschall
Copy link
Contributor

The optional ResultSet#getObject(int, Class) and
ResultSet#getObject(String, Class) methods are currently not
implemented.

Besides the conversions mentioned in appendix Appendix B, Table B-3 we
also support uniqueidentifier <-> UUID.

This commit does not include support for JSR-310 data types in order to
keep it smaller.

Fixes #6

The optional ResultSet#getObject(int, Class) and
ResultSet#getObject(String, Class) methods are currently not
implemented.

Besides the conversions mentioned in appendix Appendix B, Table B-3 we
also support uniqueidentifier <-> UUID.

This commit does not include support for JSR-310 data types in order to
keep it smaller.

Fixes #6
@codecov-io
Copy link

codecov-io commented May 19, 2017

Codecov Report

Merging #304 into dev will increase coverage by 1.19%.
The diff coverage is 80.86%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #304      +/-   ##
============================================
+ Coverage     42.69%   43.89%   +1.19%     
- Complexity     2290     2336      +46     
============================================
  Files           107      107              
  Lines         30220    30930     +710     
  Branches       5858     6087     +229     
============================================
+ Hits          12903    13576     +673     
+ Misses        15148    15031     -117     
- Partials       2169     2323     +154
Flag Coverage Δ Complexity Δ
#JDBC41 43.77% <80.86%> (+1.25%) 2329 <50> (+46) ⬆️
#JDBC42 43.83% <80.86%> (+1.27%) 2332 <50> (+53) ⬆️
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/SQLServerResource.java 100% <ø> (ø) 4 <0> (ø) ⬇️
...oft/sqlserver/jdbc/SQLServerCallableStatement.java 21.65% <64.17%> (+9.11%) 71 <16> (+32) ⬆️
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 50.14% <89.65%> (+1.46%) 78 <6> (+4) ⬆️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 31.15% <93.93%> (+3.16%) 234 <28> (+33) ⬆️
src/main/java/com/microsoft/sqlserver/jdbc/AE.java 45.57% <0%> (-4.09%) 0% <0%> (ø)
src/main/java/microsoft/sql/DateTimeOffset.java 37.14% <0%> (-2.86%) 8% <0%> (-2%)
...ava/com/microsoft/sqlserver/jdbc/ScrollWindow.java 73.17% <0%> (-2.44%) 17% <0%> (-2%)
...oft/sqlserver/jdbc/SQLServerResultSetMetaData.java 40.14% <0%> (-0.71%) 22% <0%> (-1%)
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 51.88% <0%> (-0.43%) 379% <0%> (-41%)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4b87c3...30865ab. Read the comment docs.

@msftclas
Copy link

@marschall, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@marschall
Copy link
Contributor Author

marschall commented May 19, 2017

At least H2 and PostgreSQL have a G|UUID type as well and support reading UUIDs with getObject(int|String, UUID.class) as well.

@xiangyushawn xiangyushawn reopened this Jul 5, 2017
@xiangyushawn xiangyushawn merged commit 9172170 into microsoft:dev Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants