Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement JDBC 4.1 getObject #6

Closed
marschall opened this issue Nov 19, 2016 · 8 comments
Closed

Implement JDBC 4.1 getObject #6

marschall opened this issue Nov 19, 2016 · 8 comments
Assignees
Labels
Enhancement An enhancement to the driver. Lower priority than bugs.

Comments

@marschall
Copy link
Contributor

The driver currently lacks critical JDBC 4.1 methods. Most notably:

These limitations make it impossible to retrieve Java 8 Date and Time API data types.

@ajlam ajlam added the Enhancement An enhancement to the driver. Lower priority than bugs. label Nov 21, 2016
@ajlam
Copy link
Member

ajlam commented Nov 21, 2016

@marschall - would require adding new APIs. Filing as an enhancement and for follow-up investigation.

@marschall
Copy link
Contributor Author

I don't see this as an enhancement but as a compliance issue. These are existing JDBC 4.1 APIs. I do not see how you can claim compliance yet do not implement these APIs.

@ajlam
Copy link
Member

ajlam commented Nov 21, 2016

@marschall - I am not 100% well versed with the JDBC 4.1 API. We are following up to understand if the APIs you mentioned above are completely required for JDBC 4.1 compliance.

@v-mabarw
Copy link

@marschall @ajlam The JDBC specification identifies features that are required for compliance as well as enhancements that are considered optional. I've confirmed that the getObject methods mentioned here fall under the optional category (if you want more detail, you can refer to Chapter 6 in the 4.1 specification)

@marschall
Copy link
Contributor Author

@v-mabarw I see, chapter 6.3, you are correct. You may want to delete these comments as they are all in optional methods (and contain a typo).

@v-mabarw
Copy link

@marschall Thanks for pointing out those comments, we'll update them & fix the typo.

Am I correct in understanding that you are still looking for those APIs to be implemented?

@marschall
Copy link
Contributor Author

@v-mabarw yes, I would still like to see these methods implemented. The main reason being that these methods are the only way to use Java 8 Date and Time types.

@v-nisidh v-nisidh added this to the Next Tasks milestone Feb 6, 2017
@v-nisidh v-nisidh added up for grabs and removed Enhancement An enhancement to the driver. Lower priority than bugs. labels Feb 14, 2017
@ajlam ajlam added the Enhancement An enhancement to the driver. Lower priority than bugs. label Feb 14, 2017
@xiangyushawn
Copy link
Contributor

Thank you @marschall the PR is merged now. We very appreciate your contribution!

lilgreenbird pushed a commit to lilgreenbird/mssql-jdbc that referenced this issue Aug 13, 2020
lilgreenbird pushed a commit to lilgreenbird/mssql-jdbc that referenced this issue Oct 8, 2020
David-Engel pushed a commit to David-Engel/mssql-jdbc that referenced this issue Oct 7, 2021
Updated getConnectionFields to account for SQLServerConnectionPoolProxy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement An enhancement to the driver. Lower priority than bugs.
Projects
None yet
Development

No branches or pull requests

5 participants