-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement JDBC 4.1 getObject #6
Comments
@marschall - would require adding new APIs. Filing as an enhancement and for follow-up investigation. |
I don't see this as an enhancement but as a compliance issue. These are existing JDBC 4.1 APIs. I do not see how you can claim compliance yet do not implement these APIs. |
@marschall - I am not 100% well versed with the JDBC 4.1 API. We are following up to understand if the APIs you mentioned above are completely required for JDBC 4.1 compliance. |
@marschall @ajlam The JDBC specification identifies features that are required for compliance as well as enhancements that are considered optional. I've confirmed that the getObject methods mentioned here fall under the optional category (if you want more detail, you can refer to Chapter 6 in the 4.1 specification) |
@v-mabarw I see, chapter 6.3, you are correct. You may want to delete these comments as they are all in optional methods (and contain a typo). |
@marschall Thanks for pointing out those comments, we'll update them & fix the typo. Am I correct in understanding that you are still looking for those APIs to be implemented? |
@v-mabarw yes, I would still like to see these methods implemented. The main reason being that these methods are the only way to use Java 8 Date and Time types. |
Thank you @marschall the PR is merged now. We very appreciate your contribution! |
Fix unit test
Updated getConnectionFields to account for SQLServerConnectionPoolProxy
The driver currently lacks critical JDBC 4.1 methods. Most notably:
These limitations make it impossible to retrieve Java 8 Date and Time API data types.
The text was updated successfully, but these errors were encountered: