Remove code that removed focus visual in SelectionFollowsFocus mode #3190
Conversation
dev/NavigationView/NavigationView.h
Outdated
| @@ -165,7 +165,6 @@ class NavigationView : | |||
| void UpdateVisualState(bool useTransitions = false); | |||
| void UpdateVisualStateForOverflowButton(); | |||
| void UpdateLeftNavigationOnlyVisualState(bool useTransitions); | |||
| void UpdateNavigationViewUseSystemVisual(); | |||
| static void PropagateShowFocusVisualToAllNavigationViewItemsInRepeater(winrt::ItemsRepeater const& ir, bool showFocusVisual); | |||
There was a problem hiding this comment.
PropagateShowFocusVisualToAllNavigationViewItemsInRepeater [](start = 16, length = 58)
I think this isn't called anymore?
There was a problem hiding this comment.
Yes, this isn't used anymore, missed that function. Is removed now.
| @@ -508,10 +508,6 @@ | |||
| </Setter> | |||
| </Style> | |||
|
|
|||
| <!--Note: Even though UseSystemFocusVisuals is set to True here in the Style, and because | |||
| bindings in Styles are only evaluated once, we were unable to bring a TemplateSettings.UseSystemFocusVisuals | |||
There was a problem hiding this comment.
bindings in Styles are only evaluated once [](start = 4, length = 42)
@chingucoding and @Felix-Dev does this tid bit explain some of the Binding issues you've been seeing in other PRs?
There was a problem hiding this comment.
That certainly explains the issues I have seen. So the workaround is to essentially handle the binding inside the control logic then?
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…electionfollowsfocus
|
@chingucoding The pipeline fix just went in, could you please merge master into this PR? |
|
@chingucoding I think this one was missed? |
|
5f20943 was the merge with master which funnily came in before your message to merge with master. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Description
When SelectionFollowsFocus was set to enabled we disabled the focus visual, which isn't desired anymore.
Motivation and Context
Fixes #1539
How Has This Been Tested?
Tested manually:
Screenshots (if appropriate):