Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting SelectionFollowsFocus causes focus rect to not render #1539

Closed
YuliKl opened this issue Nov 4, 2019 · 1 comment · Fixed by #3190
Closed

Setting SelectionFollowsFocus causes focus rect to not render #1539

YuliKl opened this issue Nov 4, 2019 · 1 comment · Fixed by #3190
Assignees
Labels
area-NavigationView NavView control bug Something isn't working team-Controls Issue for the Controls team

Comments

@YuliKl
Copy link

YuliKl commented Nov 4, 2019

Describe the bug

When NavigationView's SelectionFollowsFocus="Enabled", the menu items no longer render focus rects while they have keyboard focus.

Steps to reproduce the bug

Steps to reproduce the behavior:

  1. Create new test app with
    <muxc:NavigationView PaneDisplayMode="Auto" SelectionFollowsFocus="Enabled">
        <muxc:NavigationView.MenuItems>
            <muxc:NavigationViewItem Icon="Play" Content="Menu Item1" Tag="SamplePage1" />
            <muxc:NavigationViewItem Icon="Save" Content="Menu Item2" Tag="SamplePage2" />
        </muxc:NavigationView.MenuItems>
        <Frame x:Name="contentFrame">
            <Grid>
                <Button>Hello</Button>
            </Grid>
        </Frame>
    </muxc:NavigationView>
  1. Tab through the controls in the app
  2. Note that the focus rect disappears between hamburger and settings buttons.
  3. Change SelectionFollowsFocus to Disabled.
  4. Note focus draws as expected.

Expected behavior

When one of the MenuItems has keyboard focus, a focus rect is drawn around it.

Screenshots
NavigationViewFocus

Additional context

Copied from internal bug

@YuliKl YuliKl added bug Something isn't working area-NavigationView NavView control labels Nov 4, 2019
@jevansaks jevansaks added the needs-triage Issue needs to be triaged by the area owners label Nov 6, 2019
@jevansaks jevansaks added team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Nov 6, 2019
@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Nov 7, 2019
@jevansaks jevansaks removed the needs-triage Issue needs to be triaged by the area owners label Nov 7, 2019
@marcelwgn
Copy link
Collaborator

I would like to look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-NavigationView NavView control bug Something isn't working team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants