-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add loopworkspace extension to FileIconType #28553
Conversation
📊 Bundle size report🤖 This report was generated against 3f65c7cfb7dad7a2c55b649778ced4c43cfc5bb1 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6f7ba65:
|
Asset size changes
Baseline commit: 3f65c7cfb7dad7a2c55b649778ced4c43cfc5bb1 (build) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks correct! The icon referenced by loopworkspace
will be pulled from the latest CDN version in the Fluent iconography figma file at the appropriate format, size and scaling factor when you pass it this given FileIconType.
This PR is to unblock Loop to be able to use the loopworkspace file type icons, by adding this type to the
FileIconType
enum. Fixes #28554