Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loopworkspace extension to FileIconType #28553

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

tomi-msft
Copy link
Contributor

@tomi-msft tomi-msft commented Jul 17, 2023

This PR is to unblock Loop to be able to use the loopworkspace file type icons, by adding this type to the FileIconType enum. Fixes #28554

@tomi-msft tomi-msft requested review from a team, Jahnp and bigbadcapers as code owners July 17, 2023 19:56
@github-actions github-actions bot added this to the July Project Cycle Q3 2023 milestone Jul 17, 2023
@fabricteam
Copy link
Collaborator

fabricteam commented Jul 17, 2023

📊 Bundle size report

🤖 This report was generated against 3f65c7cfb7dad7a2c55b649778ced4c43cfc5bb1

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 17, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6f7ba65:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Jul 17, 2023

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react fluentui-react-SelectableOption 724 bytes  Deleted       BelowBaseline     -724 bytes
office-ui-fabric-react fluentui-react-WindowProvider 1.059 kB  Deleted       BelowBaseline     -1.059 kB
office-ui-fabric-react keyboard-key 4.59 kB  Deleted       BelowBaseline     -4.59 kB
office-ui-fabric-react fluentui-react-DateTimeUtilities 5.244 kB  Deleted       BelowBaseline     -5.244 kB
office-ui-fabric-react fluentui-react-Color 7.498 kB  Deleted       BelowBaseline     -7.498 kB
office-ui-fabric-react fluentui-react-ResponsiveMode 7.967 kB  Deleted       BelowBaseline     -7.967 kB
office-ui-fabric-react fluentui-react-DragDrop 8.393 kB  Deleted       BelowBaseline     -8.393 kB
office-ui-fabric-react fluentui-react-northstar-Debug 10.621 kB  Deleted       BelowBaseline     -10.621 kB
office-ui-fabric-react fluentui-react-Popup 12.012 kB  Deleted       BelowBaseline     -12.012 kB
office-ui-fabric-react fluentui-react-ThemeGenerator 12.106 kB  Deleted       BelowBaseline     -12.106 kB
office-ui-fabric-react fluentui-react-ResizeGroup 13.266 kB  Deleted       BelowBaseline     -13.266 kB
office-ui-fabric-react fluentui-react-KeytipData 13.522 kB  Deleted       BelowBaseline     -13.522 kB
office-ui-fabric-react fluentui-react-Autofill 14.994 kB  Deleted       BelowBaseline     -14.994 kB
office-ui-fabric-react fluentui-react-FocusTrapZone 15.627 kB  Deleted       BelowBaseline     -15.627 kB
office-ui-fabric-react fluentui-react-Divider 17.63 kB  Deleted       BelowBaseline     -17.63 kB
office-ui-fabric-react fluentui-react-Positioning 21.148 kB  Deleted       BelowBaseline     -21.148 kB
office-ui-fabric-react fluentui-react-Viewport 22.933 kB  Deleted       BelowBaseline     -22.933 kB
office-ui-fabric-react fluentui-react-OverflowSet 30.777 kB  Deleted       BelowBaseline     -30.777 kB
office-ui-fabric-react fluentui-react-Sticky 31.572 kB  Deleted       BelowBaseline     -31.572 kB
office-ui-fabric-react fluentui-react-DraggableZone 33.04 kB  Deleted       BelowBaseline     -33.04 kB
office-ui-fabric-react fluentui-react-Separator 33.397 kB  Deleted       BelowBaseline     -33.397 kB
office-ui-fabric-react fluentui-react-Text 35.931 kB  Deleted       BelowBaseline     -35.931 kB
office-ui-fabric-react fluentui-react-Label 36.347 kB  Deleted       BelowBaseline     -36.347 kB
office-ui-fabric-react fluentui-react-Announced 36.473 kB  Deleted       BelowBaseline     -36.473 kB
office-ui-fabric-react fluentui-react-northstar-Design 36.723 kB  Deleted       BelowBaseline     -36.723 kB
office-ui-fabric-react fluentui-react-ProgressIndicator 37.498 kB  Deleted       BelowBaseline     -37.498 kB
office-ui-fabric-react fluentui-react-Link 37.673 kB  Deleted       BelowBaseline     -37.673 kB
office-ui-fabric-react fluentui-react-northstar-SvgIcon 37.687 kB  Deleted       BelowBaseline     -37.687 kB
office-ui-fabric-react fluentui-react-List 37.733 kB  Deleted       BelowBaseline     -37.733 kB
office-ui-fabric-react fluentui-react-Overlay 38.784 kB  Deleted       BelowBaseline     -38.784 kB
office-ui-fabric-react fluentui-react-Spinner 39.691 kB  Deleted       BelowBaseline     -39.691 kB
office-ui-fabric-react fluentui-react-Fabric 39.75 kB  Deleted       BelowBaseline     -39.75 kB
office-ui-fabric-react fluentui-react-Stack 40.598 kB  Deleted       BelowBaseline     -40.598 kB
office-ui-fabric-react fluentui-react-Selection 41.107 kB  Deleted       BelowBaseline     -41.107 kB
office-ui-fabric-react fluentui-react-Theme 42.456 kB  Deleted       BelowBaseline     -42.456 kB
office-ui-fabric-react fluentui-react-Toggle 44.17 kB  Deleted       BelowBaseline     -44.17 kB
office-ui-fabric-react fluentui-react-Image 44.79 kB  Deleted       BelowBaseline     -44.79 kB
office-ui-fabric-react fluentui-react-Styling 44.812 kB  Deleted       BelowBaseline     -44.812 kB
office-ui-fabric-react fluentui-react-Layer 45.664 kB  Deleted       BelowBaseline     -45.664 kB
office-ui-fabric-react fluentui-react-Shimmer 47.265 kB  Deleted       BelowBaseline     -47.265 kB
office-ui-fabric-react fluentui-react-northstar-Flex 48.871 kB  Deleted       BelowBaseline     -48.871 kB
office-ui-fabric-react fluentui-react-Icon 49.74 kB  Deleted       BelowBaseline     -49.74 kB
office-ui-fabric-react fluentui-react-Check 51.062 kB  Deleted       BelowBaseline     -51.062 kB
office-ui-fabric-react fluentui-react-FocusZone 53.163 kB  Deleted       BelowBaseline     -53.163 kB
office-ui-fabric-react fluentui-react-ScrollablePane 53.331 kB  Deleted       BelowBaseline     -53.331 kB
office-ui-fabric-react fluentui-react-Slider 55.4 kB  Deleted       BelowBaseline     -55.4 kB
office-ui-fabric-react fluentui-react-PersonaPresence 55.928 kB  Deleted       BelowBaseline     -55.928 kB
office-ui-fabric-react fluentui-react-ChoiceGroupOption 56.601 kB  Deleted       BelowBaseline     -56.601 kB
office-ui-fabric-react fluentui-react-northstar-Animation 56.773 kB  Deleted       BelowBaseline     -56.773 kB
office-ui-fabric-react fluentui-react-Checkbox 57.791 kB  Deleted       BelowBaseline     -57.791 kB
office-ui-fabric-react fluentui-react-northstar-Portal 59.811 kB  Deleted       BelowBaseline     -59.811 kB
office-ui-fabric-react fluentui-react-ChoiceGroup 63.054 kB  Deleted       BelowBaseline     -63.054 kB
office-ui-fabric-react fluentui-react-Icons 65.829 kB  Deleted       BelowBaseline     -65.829 kB
office-ui-fabric-react fluentui-react-ActivityItem 68.833 kB  Deleted       BelowBaseline     -68.833 kB
office-ui-fabric-react fluentui-react-PositioningContainer 69.875 kB  Deleted       BelowBaseline     -69.875 kB
office-ui-fabric-react fluentui-react-MarqueeSelection 71.512 kB  Deleted       BelowBaseline     -71.512 kB
office-ui-fabric-react fluentui-react-Utilities 71.563 kB  Deleted       BelowBaseline     -71.563 kB
office-ui-fabric-react fluentui-react-northstar-Grid 72.891 kB  Deleted       BelowBaseline     -72.891 kB
office-ui-fabric-react fluentui-react-northstar-Image 76.159 kB  Deleted       BelowBaseline     -76.159 kB
office-ui-fabric-react fluentui-react-northstar-Text 76.755 kB  Deleted       BelowBaseline     -76.755 kB
office-ui-fabric-react fluentui-react-northstar-TextArea 76.883 kB  Deleted       BelowBaseline     -76.883 kB
office-ui-fabric-react fluentui-react-Keytip 76.941 kB  Deleted       BelowBaseline     -76.941 kB
office-ui-fabric-react fluentui-react-northstar-Header 77.448 kB  Deleted       BelowBaseline     -77.448 kB
office-ui-fabric-react fluentui-react-northstar-Box 77.974 kB  Deleted       BelowBaseline     -77.974 kB
office-ui-fabric-react fluentui-react-northstar-Layout 78.055 kB  Deleted       BelowBaseline     -78.055 kB
office-ui-fabric-react fluentui-react-northstar-Video 78.187 kB  Deleted       BelowBaseline     -78.187 kB
office-ui-fabric-react fluentui-react-TextField 78.41 kB  Deleted       BelowBaseline     -78.41 kB
office-ui-fabric-react fluentui-react-Rating 78.892 kB  Deleted       BelowBaseline     -78.892 kB
office-ui-fabric-react fluentui-react-northstar-Segment 78.983 kB  Deleted       BelowBaseline     -78.983 kB
office-ui-fabric-react fluentui-react-northstar-Status 79.184 kB  Deleted       BelowBaseline     -79.184 kB
office-ui-fabric-react fluentui-react-Callout 79.192 kB  Deleted       BelowBaseline     -79.192 kB
office-ui-fabric-react fluentui-react-northstar-Divider 79.414 kB  Deleted       BelowBaseline     -79.414 kB
office-ui-fabric-react fluentui-react-northstar-Reaction 80.16 kB  Deleted       BelowBaseline     -80.16 kB
office-ui-fabric-react fluentui-react-northstar-Skeleton 80.46 kB  Deleted       BelowBaseline     -80.46 kB
office-ui-fabric-react fluentui-react-northstar-Label 80.804 kB  Deleted       BelowBaseline     -80.804 kB
office-ui-fabric-react fluentui-react-northstar-ItemLayout 80.989 kB  Deleted       BelowBaseline     -80.989 kB
office-ui-fabric-react fluentui-react-northstar-Loader 81.579 kB  Deleted       BelowBaseline     -81.579 kB
office-ui-fabric-react fluentui-react-Tooltip 82.446 kB  Deleted       BelowBaseline     -82.446 kB
office-ui-fabric-react fluentui-react-northstar-Breadcrumb 82.964 kB  Deleted       BelowBaseline     -82.964 kB
office-ui-fabric-react fluentui-react-northstar-Checkbox 83.063 kB  Deleted       BelowBaseline     -83.063 kB
office-ui-fabric-react fluentui-react-northstar-Avatar 83.329 kB  Deleted       BelowBaseline     -83.329 kB
office-ui-fabric-react fluentui-react-northstar-Table 84.172 kB  Deleted       BelowBaseline     -84.172 kB
office-ui-fabric-react fluentui-react-northstar-Embed 84.77 kB  Deleted       BelowBaseline     -84.77 kB
office-ui-fabric-react fluentui-react-northstar-Card 85.931 kB  Deleted       BelowBaseline     -85.931 kB
office-ui-fabric-react fluentui-react-northstar-Button 86.433 kB  Deleted       BelowBaseline     -86.433 kB
office-ui-fabric-react fluentui-react-northstar-RadioGroup 86.755 kB  Deleted       BelowBaseline     -86.755 kB
office-ui-fabric-react fluentui-react-northstar-Pill 86.879 kB  Deleted       BelowBaseline     -86.879 kB
office-ui-fabric-react fluentui-react-northstar-Slider 87.909 kB  Deleted       BelowBaseline     -87.909 kB
office-ui-fabric-react fluentui-react-Coachmark 88.666 kB  Deleted       BelowBaseline     -88.666 kB
office-ui-fabric-react fluentui-react-northstar-Accordion 89.075 kB  Deleted       BelowBaseline     -89.075 kB
office-ui-fabric-react fluentui-react-Modal 89.871 kB  Deleted       BelowBaseline     -89.871 kB
office-ui-fabric-react fluentui-react-northstar-Attachment 90.341 kB  Deleted       BelowBaseline     -90.341 kB
office-ui-fabric-react fluentui-react-northstar-Alert 91.103 kB  Deleted       BelowBaseline     -91.103 kB
office-ui-fabric-react fluentui-react-northstar-Tree 91.442 kB  Deleted       BelowBaseline     -91.442 kB
office-ui-fabric-react fluentui-react-northstar-Input 91.733 kB  Deleted       BelowBaseline     -91.733 kB
office-ui-fabric-react fluentui-react-HoverCard 92.164 kB  Deleted       BelowBaseline     -92.164 kB
office-ui-fabric-react fluentui-react-northstar-List 92.24 kB  Deleted       BelowBaseline     -92.24 kB
office-ui-fabric-react fluentui-react-ExtendedPicker 94.558 kB  Deleted       BelowBaseline     -94.558 kB
office-ui-fabric-react fluentui-react-northstar-Provider 94.914 kB  Deleted       BelowBaseline     -94.914 kB
office-ui-fabric-react fluentui-react-northstar-Form 96.154 kB  Deleted       BelowBaseline     -96.154 kB
office-ui-fabric-react fluentui-react-KeytipLayer 98.227 kB  Deleted       BelowBaseline     -98.227 kB
office-ui-fabric-react fluentui-react-WeeklyDayPicker 98.664 kB  Deleted       BelowBaseline     -98.664 kB
office-ui-fabric-react fluentui-react-Keytips 100.981 kB  Deleted       BelowBaseline     -100.981 kB
office-ui-fabric-react fluentui-react-northstar-Carousel 109.432 kB  Deleted       BelowBaseline     -109.432 kB
office-ui-fabric-react fluentui-react-Persona 109.926 kB  Deleted       BelowBaseline     -109.926 kB
office-ui-fabric-react fluentui-react-PersonaCoin 109.926 kB  Deleted       BelowBaseline     -109.926 kB
office-ui-fabric-react fluentui-react-northstar-Tooltip 112.1 kB  Deleted       BelowBaseline     -112.1 kB
office-ui-fabric-react fluentui-react-northstar-Dialog 117.057 kB  Deleted       BelowBaseline     -117.057 kB
office-ui-fabric-react fluentui-react-GroupedListV2 118.234 kB  Deleted       BelowBaseline     -118.234 kB
office-ui-fabric-react fluentui-react-Calendar 118.64 kB  Deleted       BelowBaseline     -118.64 kB
office-ui-fabric-react fluentui-react-ColorPicker 127.834 kB  Deleted       BelowBaseline     -127.834 kB
office-ui-fabric-react fluentui-react-GroupedList 130.546 kB  Deleted       BelowBaseline     -130.546 kB
office-ui-fabric-react fluentui-react-northstar-Menu 132.497 kB  Deleted       BelowBaseline     -132.497 kB
office-ui-fabric-react fluentui-react-northstar-Popup 138.468 kB  Deleted       BelowBaseline     -138.468 kB
office-ui-fabric-react fluentui-react-ContextualMenu 148.361 kB  Deleted       BelowBaseline     -148.361 kB
office-ui-fabric-react fluentui-react-northstar-Chat 159.446 kB  Deleted       BelowBaseline     -159.446 kB
office-ui-fabric-react fluentui-react-northstar-MenuButton 168.377 kB  Deleted       BelowBaseline     -168.377 kB
office-ui-fabric-react fluentui-react-Grid 173.664 kB  Deleted       BelowBaseline     -173.664 kB
office-ui-fabric-react fluentui-react-ButtonGrid 173.664 kB  Deleted       BelowBaseline     -173.664 kB
office-ui-fabric-react fluentui-react-DatePicker 178.302 kB  Deleted       BelowBaseline     -178.302 kB
office-ui-fabric-react fluentui-react-SearchBox 180.728 kB  Deleted       BelowBaseline     -180.728 kB
office-ui-fabric-react fluentui-react-northstar-Toolbar 180.854 kB  Deleted       BelowBaseline     -180.854 kB
office-ui-fabric-react fluentui-react-Nav 181.012 kB  Deleted       BelowBaseline     -181.012 kB
office-ui-fabric-react fluentui-react-Pivot 181.998 kB  Deleted       BelowBaseline     -181.998 kB
office-ui-fabric-react fluentui-react-MessageBar 182.353 kB  Deleted       BelowBaseline     -182.353 kB
office-ui-fabric-react fluentui-react-SwatchColorPicker 183.633 kB  Deleted       BelowBaseline     -183.633 kB
office-ui-fabric-react fluentui-react-SpinButton 184.407 kB  Deleted       BelowBaseline     -184.407 kB
office-ui-fabric-react fluentui-react-northstar-SplitButton 184.697 kB  Deleted       BelowBaseline     -184.697 kB
office-ui-fabric-react fluentui-react-Button 187.919 kB  Deleted       BelowBaseline     -187.919 kB
office-ui-fabric-react fluentui-react-Panel 192.102 kB  Deleted       BelowBaseline     -192.102 kB
office-ui-fabric-react fluentui-react-Breadcrumb 193.626 kB  Deleted       BelowBaseline     -193.626 kB
office-ui-fabric-react fluentui-react-northstar-Datepicker 193.768 kB  Deleted       BelowBaseline     -193.768 kB
office-ui-fabric-react fluentui-react-CommandBar 194.738 kB  Deleted       BelowBaseline     -194.738 kB
office-ui-fabric-react fluentui-react-TeachingBubble 197.526 kB  Deleted       BelowBaseline     -197.526 kB
office-ui-fabric-react fluentui-react-Dialog 202.521 kB  Deleted       BelowBaseline     -202.521 kB
office-ui-fabric-react fluentui-react-Facepile 203.538 kB  Deleted       BelowBaseline     -203.538 kB
office-ui-fabric-react fluentui-react-northstar-Dropdown 203.774 kB  Deleted       BelowBaseline     -203.774 kB
office-ui-fabric-react fluentui-react-DocumentCard 208.628 kB  Deleted       BelowBaseline     -208.628 kB
office-ui-fabric-react fluentui-react-SelectedItemsList 224.182 kB  Deleted       BelowBaseline     -224.182 kB
office-ui-fabric-react fluentui-react-DetailsList 224.651 kB  Deleted       BelowBaseline     -224.651 kB
office-ui-fabric-react fluentui-react-Dropdown 224.836 kB  Deleted       BelowBaseline     -224.836 kB
office-ui-fabric-react fluentui-react-TimePicker 231.91 kB  Deleted       BelowBaseline     -231.91 kB
office-ui-fabric-react fluentui-react-FloatingPicker 233.776 kB  Deleted       BelowBaseline     -233.776 kB
office-ui-fabric-react fluentui-react-ShimmeredDetailsList 235.403 kB  Deleted       BelowBaseline     -235.403 kB
office-ui-fabric-react fluentui-react-ComboBox 241.758 kB  Deleted       BelowBaseline     -241.758 kB
office-ui-fabric-react fluentui-react-Pickers 284.226 kB  Deleted       BelowBaseline     -284.226 kB

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: 3f65c7cfb7dad7a2c55b649778ced4c43cfc5bb1 (build)

Copy link
Contributor

@bigbadcapers bigbadcapers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct! The icon referenced by loopworkspace will be pulled from the latest CDN version in the Fluent iconography figma file at the appropriate format, size and scaling factor when you pass it this given FileIconType.

@tomi-msft tomi-msft merged commit 3cbeb7e into microsoft:master Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add loopworkspace to enum in FileTypeIcons
3 participants