[WIP] Enable faster rule caching for fela renderer #12412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Potential regressions comparing to master
Perf comparison
Perf tests with no regressions
|
b425f45 to
2f1a84e
Compare
added 3 commits
March 26, 2020 14:53
Updates fela's `renderRule` method to compute classNames on a more granular level: by property rather than by style object. Rather than generating a full className for an entire style object at once, it now walks the style object and generates classes for each individual property. This allows us to avoid reprocessing styles that should already be cached. NOTE: this approach does not work for monolithic classNames, since that treats an entire style object as a single entity. So, do not use this if you are using that mode.
43aec76 to
816b7cc
Compare
|
Closing in favor of #12445. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this PR up early so I can get feedback from the PR bots on performance impacts.
Updates fela's
renderRulemethod to compute classNames on a more granular level: by property rather than by style object.Rather than generating a full className for an entire style object at once, it now walks the style object and generates classes for each individual property. This allows us to avoid reprocessing styles that should already be cached.
NOTE: this approach does not work for monolithic classNames, since that treats an entire style object as a single entity. So, do not use this if you are using that mode.
Pull request checklist
$ yarn changeDescription of changes
(give an overview)
Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow