Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Performance Profiling #12474

Closed
wants to merge 2 commits into from
Closed

[WIP] Performance Profiling #12474

wants to merge 2 commits into from

Conversation

dvdzkwsk
Copy link
Contributor

@dvdzkwsk dvdzkwsk commented Mar 30, 2020

Setting up this PR to get feedback from PR bots. I have a few changes to try out, so I figured I'd restrict them to a single branch rather than opening up a flood of WIP pull requests.

Related:

Microsoft Reviewers: Open in CodeFlow

Unverified

No user is associated with the committer email.
@DustyTheBot
Copy link

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS against 869eb82

@size-auditor
Copy link

size-auditor bot commented Mar 30, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: aa90e07c6f8e27a28a3a883fb4febc2cd2eb8ae2 (build)

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Status
BaseButton 879 888
BaseButton (experiments) 1079 1031
DefaultButton 1140 1150
DefaultButton (experiments) 1972 2032
DetailsRow 3560 3520
DetailsRow (fast icons) 3438 3408
DetailsRow without styles 3328 3305
DocumentCardTitle with truncation 1600 1588
MenuButton 1497 1475
MenuButton (experiments) 3657 3587
PrimaryButton 1253 1249
PrimaryButton (experiments) 2077 2086
SplitButton 3110 3178
SplitButton (experiments) 7170 7142
Stack 490 517
Stack with Intrinsic children 1173 1154
Stack with Text children 4428 4388
Text 399 413
Toggle 953 958
Toggle (experiments) 2283 2296
button 55 67

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.62 0.54 1.15:1 2000 1244
🦄 Button.Fluent 0.11 0.2 0.55:1 5000 572
🔧 Checkbox.Fluent 0.83 0.47 1.77:1 1000 828
🔧 Dialog.Fluent 0.45 0.21 2.14:1 5000 2231
🔧 Dropdown.Fluent 3.81 0.55 6.93:1 1000 3805
🔧 Icon.Fluent 0.2 0.05 4:1 5000 1020
🎯 Image.Fluent 0.09 0.11 0.82:1 5000 459
🔧 Slider.Fluent 1.68 0.45 3.73:1 1000 1676
🔧 Text.Fluent 0.1 0.02 5:1 5000 508
🦄 Tooltip.Fluent 0.14 18 0.01:1 5000 692

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ImageMinimalPerf.default 441 395 1.12:1
FlexMinimalPerf.default 346 321 1.08:1
Image.Fluent 459 432 1.06:1
PortalMinimalPerf.default 349 331 1.05:1
ProviderMergeThemesPerf.default 1592 1517 1.05:1
Icon.Fluent 1020 967 1.05:1
DividerMinimalPerf.default 1151 1108 1.04:1
RefMinimalPerf.default 220 211 1.04:1
SliderMinimalPerf.default 1750 1676 1.04:1
StatusMinimalPerf.default 834 801 1.04:1
TooltipMinimalPerf.default 983 943 1.04:1
Text.Fluent 508 490 1.04:1
AlertMinimalPerf.default 677 659 1.03:1
BoxMinimalPerf.default 472 457 1.03:1
CarouselMinimalPerf.default 711 690 1.03:1
ChatWithPopoverPerf.default 689 667 1.03:1
ItemLayoutMinimalPerf.default 2418 2340 1.03:1
ListCommonPerf.default 1244 1212 1.03:1
ListWith60ListItems.default 1420 1379 1.03:1
MenuMinimalPerf.default 2315 2241 1.03:1
Avatar.Fluent 1244 1208 1.03:1
Checkbox.Fluent 828 806 1.03:1
GridMinimalPerf.default 1001 986 1.02:1
HeaderSlotsPerf.default 1947 1906 1.02:1
LayoutMinimalPerf.default 805 786 1.02:1
RadioGroupMinimalPerf.default 685 673 1.02:1
TableMinimalPerf.default 804 790 1.02:1
Dialog.Fluent 2231 2189 1.02:1
Slider.Fluent 1676 1638 1.02:1
CheckboxMinimalPerf.default 3613 3594 1.01:1
HierarchicalTreeMinimalPerf.default 1203 1195 1.01:1
ListMinimalPerf.default 570 564 1.01:1
ReactionMinimalPerf.default 2765 2745 1.01:1
TreeMinimalPerf.default 1427 1409 1.01:1
AttachmentSlotsPerf.default 4020 4008 1:1
ChatDuplicateMessagesPerf.default 512 514 1:1
FormMinimalPerf.default 1116 1111 1:1
InputMinimalPerf.default 1179 1177 1:1
LabelMinimalPerf.default 487 488 1:1
LoaderMinimalPerf.default 1179 1179 1:1
TextMinimalPerf.default 492 490 1:1
CustomToolbarPrototype.default 4019 4008 1:1
VideoMinimalPerf.default 1068 1065 1:1
Button.Fluent 572 573 1:1
Tooltip.Fluent 692 691 1:1
AvatarMinimalPerf.default 662 670 0.99:1
ButtonMinimalPerf.default 173 174 0.99:1
ChatMinimalPerf.default 697 701 0.99:1
DialogMinimalPerf.default 2207 2224 0.99:1
HeaderMinimalPerf.default 670 678 0.99:1
PopupMinimalPerf.default 263 265 0.99:1
ProviderMinimalPerf.default 690 694 0.99:1
SegmentMinimalPerf.default 1278 1290 0.99:1
ToolbarMinimalPerf.default 1350 1357 0.99:1
ButtonSlotsPerf.default 680 697 0.98:1
DropdownMinimalPerf.default 3877 3945 0.98:1
EmbedMinimalPerf.default 5825 5969 0.98:1
IconMinimalPerf.default 500 511 0.98:1
ListNestedPerf.default 1101 1127 0.98:1
TreeWith60ListItems.default 266 272 0.98:1
Dropdown.Fluent 3805 3880 0.98:1
AnimationMinimalPerf.default 748 772 0.97:1
AttachmentMinimalPerf.default 965 995 0.97:1
MenuButtonMinimalPerf.default 1784 1834 0.97:1
SplitButtonMinimalPerf.default 3991 4097 0.97:1
TextAreaMinimalPerf.default 3392 3499 0.97:1
CardMinimalPerf.default 451 479 0.94:1
DropdownManyItemsPerf.default 1606 1718 0.93:1
AccordionMinimalPerf.default 278 304 0.91:1

Unverified

No user is associated with the committer email.
@ecraig12345
Copy link
Member

@davezuko Are you still working on this or can we close it? (Or close and then reopen when it's ready?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants