fix check for static initialization of hash-of-maps key length. #3260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alan-Jowett
previously approved these changes
Feb 14, 2024
shpalani
approved these changes
Feb 14, 2024
matthewige
approved these changes
Feb 14, 2024
shpalani
pushed a commit
to shpalani/ebpf-for-windows
that referenced
this pull request
Feb 14, 2024
…osoft#3260) * fix check for static initialization of hash-of-maps key length. * Delete tests/bpf2c_tests/expected/xdp_adjust_head_unsafe_dll.c * Delete tests/bpf2c_tests/expected/xdp_adjust_head_unsafe_raw.c * Delete tests/bpf2c_tests/expected/xdp_adjust_head_unsafe_sys.c * fix build failure --------- Co-authored-by: Anurag Saxena <anusa@microsoft.com>
shpalani
pushed a commit
to shpalani/ebpf-for-windows
that referenced
this pull request
Feb 15, 2024
…osoft#3260) * fix check for static initialization of hash-of-maps key length. * Delete tests/bpf2c_tests/expected/xdp_adjust_head_unsafe_dll.c * Delete tests/bpf2c_tests/expected/xdp_adjust_head_unsafe_raw.c * Delete tests/bpf2c_tests/expected/xdp_adjust_head_unsafe_sys.c * fix build failure --------- Co-authored-by: Anurag Saxena <anusa@microsoft.com>
shpalani
pushed a commit
to shpalani/ebpf-for-windows
that referenced
this pull request
Feb 15, 2024
…osoft#3260) * fix check for static initialization of hash-of-maps key length. * Delete tests/bpf2c_tests/expected/xdp_adjust_head_unsafe_dll.c * Delete tests/bpf2c_tests/expected/xdp_adjust_head_unsafe_raw.c * Delete tests/bpf2c_tests/expected/xdp_adjust_head_unsafe_sys.c * fix build failure --------- Co-authored-by: Anurag Saxena <anusa@microsoft.com>
shpalani
added a commit
that referenced
this pull request
Feb 16, 2024
* fix check for static initialization of hash-of-maps key length. (#3260) * fix check for static initialization of hash-of-maps key length. * Delete tests/bpf2c_tests/expected/xdp_adjust_head_unsafe_dll.c * Delete tests/bpf2c_tests/expected/xdp_adjust_head_unsafe_raw.c * Delete tests/bpf2c_tests/expected/xdp_adjust_head_unsafe_sys.c * fix build failure --------- Co-authored-by: Anurag Saxena <anusa@microsoft.com> * Revert "Helper reallocate packet (#3110)" (#3263) This reverts commit 13eed74. * bump version to 0.14.1 * fix test --------- Co-authored-by: Shankar Seal <74580197+shankarseal@users.noreply.github.com> Co-authored-by: Anurag Saxena <anusa@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #3259. Moved the check for key length restriction only if there are more than one values statically initialized.
Testing
Added non-initializing map in test program.
Documentation
No.
Installation
No.