-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helper reallocate packet #3110
Merged
Alan-Jowett
merged 4 commits into
microsoft:main
from
shankarseal:helper_reallocate_packet
Dec 11, 2023
Merged
Helper reallocate packet #3110
Alan-Jowett
merged 4 commits into
microsoft:main
from
shankarseal:helper_reallocate_packet
Dec 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3659f71
to
1db057d
Compare
mtfriesen
reviewed
Dec 8, 2023
dthaler
reviewed
Dec 8, 2023
1db057d
to
dfc180a
Compare
dfc180a
to
b043234
Compare
mtfriesen
approved these changes
Dec 11, 2023
dthaler
approved these changes
Dec 11, 2023
Alan-Jowett
approved these changes
Dec 11, 2023
shankarseal
added a commit
to shankarseal/ebpf-for-windows
that referenced
this pull request
Feb 14, 2024
This reverts commit 13eed74.
Closed
shpalani
pushed a commit
to shpalani/ebpf-for-windows
that referenced
this pull request
Feb 15, 2024
This reverts commit 13eed74.
shpalani
pushed a commit
to shpalani/ebpf-for-windows
that referenced
this pull request
Feb 15, 2024
This reverts commit 13eed74.
shpalani
added a commit
that referenced
this pull request
Feb 16, 2024
* fix check for static initialization of hash-of-maps key length. (#3260) * fix check for static initialization of hash-of-maps key length. * Delete tests/bpf2c_tests/expected/xdp_adjust_head_unsafe_dll.c * Delete tests/bpf2c_tests/expected/xdp_adjust_head_unsafe_raw.c * Delete tests/bpf2c_tests/expected/xdp_adjust_head_unsafe_sys.c * fix build failure --------- Co-authored-by: Anurag Saxena <anusa@microsoft.com> * Revert "Helper reallocate packet (#3110)" (#3263) This reverts commit 13eed74. * bump version to 0.14.1 * fix test --------- Co-authored-by: Shankar Seal <74580197+shankarseal@users.noreply.github.com> Co-authored-by: Anurag Saxena <anusa@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #3090. A
reallocate_packet
flag is added to the helper function prototype metadata, to pass onto the PREVAIL verifier, to validate programs that uses any helper function that may change the packet pointers such asxdp_adjust_head
.Testing
A new netsh tests is added that tries to load an unsafe XDP program and fails.
Documentation
Updated extension documentation.
Installation
No changes to installation.