Prefer HKCU over HKLM for ebpf store #2382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthaler
previously approved these changes
Apr 26, 2023
|
@saxena-anurag rebase to pick up scorecards fix |
Alan-Jowett
previously approved these changes
Apr 26, 2023
465da1a to
7c24663
Compare
gtrevi
approved these changes
Apr 27, 2023
dthaler
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2381
Fixes #2360
Description
If netebpfext is running, it populates HKLM ebpf store. ebpfapi has logic to prefer HKLM over KHCU, if HKLM is present. This causes the build to fail as the HKLM store will not contain data related to sample_ext.
Fix is to prefer HKCU over KHLM.
Note: This issue should be completely fixed once #2339 is fixed.
Testing
CICD
Documentation
NA