Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample project fails to build on Visual Studio. #2360

Closed
gtrevi opened this issue Apr 21, 2023 · 1 comment · Fixed by #2382
Closed

sample project fails to build on Visual Studio. #2360

gtrevi opened this issue Apr 21, 2023 · 1 comment · Fixed by #2382
Assignees
Labels
bug Something isn't working triaged Discussed in a triage meeting
Milestone

Comments

@gtrevi
Copy link
Contributor

gtrevi commented Apr 21, 2023

After recently cloning the repo and rebuilding main from Visual Studio, either in Debug or Release, the sample project fails to build, cascading failures in the installer (which harvests its outputs).

All external submodules, projects & nuget packages are successfully regenerated from scratch, as documented here.
Repetitive errors are:

image

Repro steps

// Developer Command Prompt with privilege
git clone <repo URL>
git submodule update --recursive --init
cmake -G "Visual Studio 17 2022" -S external\ebpf-verifier -B external\ebpf-verifier\build
cmake -G "Visual Studio 17 2022" -S external\catch2 -B external\catch2\build -DBUILD_TESTING=OFF
cmake -G "Visual Studio 17 2022" -S external\ubpf -B external\ubpf\build
nuget restore ebpf-for-windows.sln
 
// Go to Visual Studio (no need for admin privilege)
Rebuild solution
<build is NOT successful - as per above>
@gtrevi gtrevi added the bug Something isn't working label Apr 21, 2023
@dahavey dahavey added the triaged Discussed in a triage meeting label Apr 24, 2023
@gtrevi gtrevi self-assigned this Apr 24, 2023
@dahavey dahavey added this to the 2305 milestone Apr 24, 2023
@gtrevi
Copy link
Contributor Author

gtrevi commented Apr 27, 2023

After syncing my fork to the latest commit (i.e. up to the one from #2383), most of the errors have gone, although, I'm still seeing just a few more (4 exactly):

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaged Discussed in a triage meeting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants