Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task-Centric Memory #5227
base: main
Are you sure you want to change the base?
Task-Centric Memory #5227
Changes from 112 commits
442a9d8
f8584cd
607e7ff
b045636
63b28d7
b921d83
9dfb074
93a5ca4
2cb9344
878f458
21562f1
3a40b30
8622c5e
20b26c1
9d47227
52d4e00
6b15777
a18674c
52e213e
a440b0a
cab51f1
d91e58c
f1d7a2f
17d4c42
19654e8
7aa20c1
83a7ddc
3047c1c
1f20b79
de4c12b
a9d6108
d67e2cc
6470fd8
b025199
4f9267c
db34844
c780852
fa688f7
43bda2f
be081b3
29d1494
8e9a550
b3fe084
077615f
8847168
4091ab3
3865cff
6c73674
db5e07b
07cb3f0
e88bd69
9b3f77d
a0dee67
7e359e9
9466ea8
4ec9bff
76c16f9
a8cd0d7
ed7fae1
93de858
1a309f9
8993aa1
fa60d5a
882d578
00cbb8c
88294d2
7d0ed63
5b3876f
21220d4
232ed0f
87ee27b
b21d140
1e88eb6
a3addc1
c6ffa43
8f66612
491964f
2ed08ae
f879487
60f8ad3
ed0a4a6
f0eceef
70db202
5e4ad48
b6c59ae
bef7e5d
1fb5ee4
1d7f4eb
516e689
ffe719a
ba14e78
2eb817e
95b1276
6633169
880df13
b4ea0ce
53da266
6a04851
ad514eb
18ae4dc
7be995d
0e01720
0416e8d
0298591
0bc0500
66029cf
d9ad986
2b2cbdb
566709b
2ef5e4a
9e7d245
1ce4cd9
494d81e
54b0faa
0b9f042
a720863
b0e72a7
dba5b55
01d8b9d
193466b
39d460a
8f9d066
94eab06
f892c18
a15bfd1
3ea8011
58ecd7e
00e27e1
4466eee
64dc3c0
e15d0eb
af362f6
4d6c9f4
261fe6f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This README is really useful but a bit too verbose. Can we please make this more concise?
Also move installation instructions and a minimal example to the top.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Figure font size is too large. Would be good to reduce and make consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Check warning on line 4 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/__init__.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/__init__.py#L1-L4
Check warning on line 6 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/__init__.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/__init__.py#L6
Check warning on line 4 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L1-L4
Check warning on line 7 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L6-L7
Check warning on line 11 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L10-L11
Check warning on line 17 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L16-L17
Check warning on line 20 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L20
Check warning on line 42 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L42
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the commont on agentic memory controller, is there a reason to have a dictionary as part of the argument list? Can we add the keys of the dictionary directly as arguments?
I understand it may be "easier" for the developer of this module to use a config dictionary. But from user experience point of view, as well as for consistency with the rest of the library, it is better to keep the argument list flat rather than introducing additional dictionary, especially the dictionary is quite small.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed per our discussion, using TypedDict in the nested-config pattern to minimize code changes by encapsulating the settings that change frequently, as when loading many settings from a single YAML file.
Check warning on line 51 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L48-L51
Check warning on line 57 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L54-L57
Check warning on line 59 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L59
Check warning on line 69 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L61-L69
Check warning on line 71 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L71
Check warning on line 74 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L73-L74
Check warning on line 76 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L76
Check warning on line 87 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L79-L87
Check warning on line 91 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L90-L91
Check warning on line 93 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L93
Check warning on line 95 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L95
Check warning on line 100 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L99-L100
Check warning on line 102 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L102
Check warning on line 107 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L106-L107
Check warning on line 109 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L109
Check warning on line 115 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L113-L115
Check warning on line 117 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L117
Check warning on line 121 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L121
Check warning on line 123 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L123
Check warning on line 133 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L127-L133
Check warning on line 135 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L135
Check warning on line 144 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L139-L144
Check warning on line 146 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L146
Check warning on line 153 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L151-L153
Check warning on line 158 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L155-L158
Check warning on line 160 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L160
Check warning on line 164 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L164
Check warning on line 169 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L167-L169
Check warning on line 177 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L172-L177
Check warning on line 179 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L179
Check warning on line 189 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L182-L189
Check warning on line 195 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L192-L195
Check warning on line 198 in python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py
python/packages/autogen-ext/src/autogen_ext/agentic_memory/_agentic_memory_bank.py#L197-L198