Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task-Centric Memory #5227
base: main
Are you sure you want to change the base?
Task-Centric Memory #5227
Changes from all commits
442a9d8
f8584cd
607e7ff
b045636
63b28d7
b921d83
9dfb074
93a5ca4
2cb9344
878f458
21562f1
3a40b30
8622c5e
20b26c1
9d47227
52d4e00
6b15777
a18674c
52e213e
a440b0a
cab51f1
d91e58c
f1d7a2f
17d4c42
19654e8
7aa20c1
83a7ddc
3047c1c
1f20b79
de4c12b
a9d6108
d67e2cc
6470fd8
b025199
4f9267c
db34844
c780852
fa688f7
43bda2f
be081b3
29d1494
8e9a550
b3fe084
077615f
8847168
4091ab3
3865cff
6c73674
db5e07b
07cb3f0
e88bd69
9b3f77d
a0dee67
7e359e9
9466ea8
4ec9bff
76c16f9
a8cd0d7
ed7fae1
93de858
1a309f9
8993aa1
fa60d5a
882d578
00cbb8c
88294d2
7d0ed63
5b3876f
21220d4
232ed0f
87ee27b
b21d140
1e88eb6
a3addc1
c6ffa43
8f66612
491964f
2ed08ae
f879487
60f8ad3
ed0a4a6
f0eceef
70db202
5e4ad48
b6c59ae
bef7e5d
1fb5ee4
1d7f4eb
516e689
ffe719a
ba14e78
2eb817e
95b1276
6633169
880df13
b4ea0ce
53da266
6a04851
ad514eb
18ae4dc
7be995d
0e01720
0416e8d
0298591
0bc0500
66029cf
d9ad986
2b2cbdb
566709b
2ef5e4a
9e7d245
1ce4cd9
494d81e
54b0faa
0b9f042
a720863
b0e72a7
dba5b55
01d8b9d
193466b
39d460a
8f9d066
94eab06
f892c18
a15bfd1
3ea8011
58ecd7e
00e27e1
4466eee
64dc3c0
e15d0eb
af362f6
4d6c9f4
261fe6f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another example perhaps like this. It can be just another code block in this file for now. In a future PR when we write a user guide for this memory module, we can move this example to the user guide.
To show how to use this as part of an agent implementation in the Core API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@victordibia could you comment how can we perhaps leverage this module as an implementation of the
autogen_core.memory.Memory
interface?Not for this PR but for future one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea.
It seems to me that the example above could be indeed implemented (to some extent) using the Memory interface.
add
maps tomemory_controller.add_memo
update_context
maps toformatted_memos = ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. I do think using the controller we can implement the
autogen_core.memory.Memory
interface. I can give it a try.If that's the case we should move this module to
autogen_ext.memory.task_centric_memory
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without losing any of the current functionality of TaskCentricMemoryController? Like learning from its own experience?? (That's
TaskCentricMemoryController.train_on_task(self, task: str, expected_answer: str)
, which requires the expected answer.)TaskCentricMemoryController is still active research so the interface is highly likely to change, as we discussed before. Why do you now want it in Core?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not moving it to core. It's staying in extension. My message earlier refers to autogen_ext module.
I am just trying to play with it and see what it takes me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New code example from @ekzhu added to the README.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ekzhu, should we wait for the results of your attempt to use
TaskCentricMemoryController
to implement theautogen_core.memory.Memory
interface before we try to clarify the relations and connections betweenTaskCentricMemory
and theautogen_core.memory.Memory
interface?Check warning on line 1 in python/packages/autogen-ext/src/autogen_ext/task_centric_memory/__init__.py
python/packages/autogen-ext/src/autogen_ext/task_centric_memory/__init__.py#L1
Check warning on line 3 in python/packages/autogen-ext/src/autogen_ext/task_centric_memory/__init__.py
python/packages/autogen-ext/src/autogen_ext/task_centric_memory/__init__.py#L3