48525090 - Skipping a test case to temporarily avoid hitting this bug #4083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AppRuntime_MathAdd()
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ng unless a TAEF parameter is specified (/p:DynamicDependency.23H1=1). We can disable only on 23H1 by default once a recent public API gets to rs_prerelease (so...next month? Uncomment the TODO comment)
DrusTheAxe
approved these changes
Jan 17, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Scottj1s
reviewed
Jan 17, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
… non-elevated behavior
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kythant
pushed a commit
that referenced
this pull request
Jan 18, 2024
…#4083) * Skipping test case: FullLifecycle_FilePathLifetime_Frameworks_WindowsAppRuntime_MathAdd() * Changed to be more nuanced about disabling behavior. Currently Skipping unless a TAEF parameter is specified (/p:DynamicDependency.23H1=1). We can disable only on 23H1 by default once a recent public API gets to rs_prerelease (so...next month? Uncomment the TODO comment) * Moved the Skip-23H1 logic to the parent Setup() to cover elevated and non-elevated behavior --------- Co-authored-by: Howard Kapustein <howardk@microsoft.com>
kythant
added a commit
that referenced
this pull request
Jan 18, 2024
kythant
added a commit
that referenced
this pull request
Jan 26, 2024
DrusTheAxe
added a commit
that referenced
this pull request
Jan 31, 2024
DrusTheAxe
added a commit
that referenced
this pull request
Feb 5, 2024
…#4083 (#4108)" (#4118)" (#4135)" (#4140) * Revert "Revert "DynamicDependencies: Use Win11 APIs if available #3704 #4083 (#4108)" (#4118)" (#4135)" This reverts commit 117ed20. * Disable DynamicDependency-delegate-to-OS by changing IsSupported() (not reverting the world) * PackageRuntimeManager tests rely on OS DynDep functionality but Setup was a parallel version check when it should have been IsSupported. Fixed so they're all using the same answer * Doh! Had the check reversed -- if (foo) should have been if (!foo). Fixed * Tweak TryCreatePackageDependency when calling the OS with an invaliud package family name we get back STATEREPOSITORY_E_DEPENDENCY_NOT_RESOLVED but should return to the caller E_INVALIDARG * Remove false skip-tests check. The surgical IsSupported disables all delegation to OS APIs. When that changes we WANT the tests to run and canary any problem * Bad test passing too long a VersionTag. Tweaked Bootstrapper to spew WIL message and deal instead of FAIL_FAST * Fixed PackageDependency.m_packageFullName was never set and .PackageId string fields (e.g. .name) weren't properly set, though they weren't used so not noticed or harm (before the resolution fix - next sentence...). Fixed TryCreatePackageDependency() wasn't resolving the dependency unless the MddCreatePackageDependencyOptions_DoNotVerifyDependencyResolution option was specified. Fixed up some test issues as well asupdates in sync with the fixes (above) * Fixed tests to correctly match (fixed) implementation * Improved some test logging. Fided up a few tests out of date with the latest behavior
bpulliam
pushed a commit
that referenced
this pull request
Feb 7, 2024
…#4083 (#4108)" (#4118)" (#4135)" (#4140) * Revert "Revert "DynamicDependencies: Use Win11 APIs if available #3704 #4083 (#4108)" (#4118)" (#4135)" This reverts commit 117ed20. * Disable DynamicDependency-delegate-to-OS by changing IsSupported() (not reverting the world) * PackageRuntimeManager tests rely on OS DynDep functionality but Setup was a parallel version check when it should have been IsSupported. Fixed so they're all using the same answer * Doh! Had the check reversed -- if (foo) should have been if (!foo). Fixed * Tweak TryCreatePackageDependency when calling the OS with an invaliud package family name we get back STATEREPOSITORY_E_DEPENDENCY_NOT_RESOLVED but should return to the caller E_INVALIDARG * Remove false skip-tests check. The surgical IsSupported disables all delegation to OS APIs. When that changes we WANT the tests to run and canary any problem * Bad test passing too long a VersionTag. Tweaked Bootstrapper to spew WIL message and deal instead of FAIL_FAST * Fixed PackageDependency.m_packageFullName was never set and .PackageId string fields (e.g. .name) weren't properly set, though they weren't used so not noticed or harm (before the resolution fix - next sentence...). Fixed TryCreatePackageDependency() wasn't resolving the dependency unless the MddCreatePackageDependencyOptions_DoNotVerifyDependencyResolution option was specified. Fixed up some test issues as well asupdates in sync with the fixes (above) * Fixed tests to correctly match (fixed) implementation * Improved some test logging. Fided up a few tests out of date with the latest behavior
bpulliam
added a commit
that referenced
this pull request
Feb 8, 2024
* Revert "Revert "DynamicDependencies: Use Win11 APIs if available #3704 #4083 (#4108)" (#4118)" (#4135)" This reverts commit 117ed20. * Disable DynamicDependency-delegate-to-OS by changing IsSupported() (not reverting the world) * PackageRuntimeManager tests rely on OS DynDep functionality but Setup was a parallel version check when it should have been IsSupported. Fixed so they're all using the same answer * Doh! Had the check reversed -- if (foo) should have been if (!foo). Fixed * Tweak TryCreatePackageDependency when calling the OS with an invaliud package family name we get back STATEREPOSITORY_E_DEPENDENCY_NOT_RESOLVED but should return to the caller E_INVALIDARG * Remove false skip-tests check. The surgical IsSupported disables all delegation to OS APIs. When that changes we WANT the tests to run and canary any problem * Bad test passing too long a VersionTag. Tweaked Bootstrapper to spew WIL message and deal instead of FAIL_FAST * Fixed PackageDependency.m_packageFullName was never set and .PackageId string fields (e.g. .name) weren't properly set, though they weren't used so not noticed or harm (before the resolution fix - next sentence...). Fixed TryCreatePackageDependency() wasn't resolving the dependency unless the MddCreatePackageDependencyOptions_DoNotVerifyDependencyResolution option was specified. Fixed up some test issues as well asupdates in sync with the fixes (above) * Fixed tests to correctly match (fixed) implementation * Improved some test logging. Fided up a few tests out of date with the latest behavior Co-authored-by: Howard Kapustein <howardk@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily skip test case FullLifecycle_FilePathLifetime_Frameworks_WindowsAppRuntime_MathAdd_Elevated() to unblock pipeline runs.
A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.