DynamicDependencies: Use Win11 APIs if available #3704

DrusTheAxe · 2023-07-05T05:17:08Z

DynamicDependencies: Use Win11 APIs if available

Leverage the the Win11 Dynamic Dependency API if available, otherwise use WinAppSDK's implementation (aka polyfill). The WinAppSDK DynDep C API handles this, thus benefiting all callers of WinAppSDK's C and WinRT DynDep API (e.g. C# via projections).

This happens on Win11 >= 22H2 (aka SV2).

NOTE: This makes the DDLM irrelevant on Win11 22H2+ (>SV2). A future (separate) PR will change the intaller to not install the DDLM packages on these systems.

NOTE: Persisted definitions aren't imported into the OS after OSupgrade to Win11 22H2+. If you create a persisted definition (LifetimeKind=FilePath|RegistryKey) on older you'll need to re-create them after the OS upgrades.

NOTE: MddGetResolvedPackageFullNameForPackageDependency()'s behavior differed from GetResolvedPackageFullNameForPackageDependency(). Both return null vs package full name when the PackageDependencyId is not resolved vs resolved but the HRESULT return value differed

PackageDependencyId	WinAppSDK	OS API
unknown	HRESULT_FROM_WIN32(ERROR_NO_MATCH)	S_OK
not resolved	S_OK	S_OK
resolved	S_OK	S_OK

MddGetResolvedPackageFullNameForPackageDependency() has been changed to match the OS API. A new OS API will be needed to distinguish between a known valid PackageDependencyId that's not been resolved yet vs an invalid/unknown PackageDependencyId.

NOTE: This change is compatible with the documented behavior. It'll be noted in the release notes.

NOTE: As a byproduct of return MddGetResolvedPackageFullNameForPackageDependency() error handling the WinRT APIs PackageDependency.GetFromId() and PackageDependency.GetFromIdForSystem() no longer fail for an unknown/invalid id e.g. PackageDependency.GetFromId("not a valid id"). Inappropriate later use will fail e.g.

var pd = PackageDependency.GetFromId("not a valid id");
var context = pd.Add();
// Add() fails and throws an exception

NOTE: A new OS API is needed to determine if a PackageDependencyId is a valid (known) value. WinAppSDK will be updated to use that when available.

https://task.ms/47326537

…ork is done. Cleanup and test revisions needed but progress

…ce during early 1.x days but not moved forward and starting to age out. Removed rather than continuing upkeep

…hen available

…olve an unresolved PackageDependency

…d()). Updated tests.

…t. Left IsSupported() unchanged (Win11 >=22H2) for now while I investigate further

DrusTheAxe · 2023-11-08T02:43:19Z

/azp run

azure-pipelines · 2023-11-08T02:43:25Z

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

DrusTheAxe · 2023-11-08T22:01:35Z

/azp run

azure-pipelines · 2023-11-08T22:01:40Z

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

azure-pipelines · 2023-11-15T22:30:15Z

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

kythant · 2023-11-21T01:39:25Z

Just a heads up. Develop branch has been renamed to become the new Main Branch and is the default branch from now on.

Scottj1s · 2023-11-21T17:39:47Z

[celebrate] Scott Jones reacted to your message:

…

________________________________ From: Kyaw Thant ***@***.***> Sent: Tuesday, November 21, 2023 1:39:36 AM To: microsoft/WindowsAppSDK ***@***.***> Cc: Scott Jones ***@***.***>; Review requested ***@***.***> Subject: Re: [microsoft/WindowsAppSDK] DynamicDependencies: Use Win11 APIs if available (PR #3704) Just a heads up. Develop branch has been renamed to become the new Main Branch and is the default branch from now on. — Reply to this email directly, view it on GitHub<#3704 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AC6IYIZM3IFH4FB6MOVMYXTYFQA5RAVCNFSM6AAAAAAZ6NSW5OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRQGA3TMNJVG4>. You are receiving this because your review was requested.Message ID: ***@***.***>

dev/DynamicDependency/API/M.AM.DD.PackageDependency.cpp

dev/DynamicDependency/API/MsixDynamicDependency.h

DrusTheAxe · 2023-11-27T20:58:36Z

/azp run

wcheng-msft

DrusTheAxe · 2023-11-29T02:38:32Z

/azp run

DrusTheAxe · 2023-11-30T04:10:15Z

/azp run

This reverts commit f0d6f3b.

…#4108) * Revert "48525090 - Skipping a test case to temporarily avoid hitting this bug (#4083)" This reverts commit 39dcd27. * Revert "DynamicDependencies: Use Win11 APIs if available (#3704)" This reverts commit f0d6f3b.

…#4109) * Revert "48525090 - Skipping a test case to temporarily avoid hitting this bug (#4083)" This reverts commit 39dcd27. * Revert "DynamicDependencies: Use Win11 APIs if available (#3704)" This reverts commit f0d6f3b.

#4083 (#4108)" This reverts commit 775edb1.

…#4118) This reverts commit 775edb1.

…4108)" (#4118)" This reverts commit daf5498.

…4108)" (#4118)" (#4135) This reverts commit daf5498.

…#4083 (#4108)" (#4118)" (#4135)" This reverts commit 117ed20.

…#4083 (#4108)" (#4118)" (#4135)" (#4140) * Revert "Revert "DynamicDependencies: Use Win11 APIs if available #3704 #4083 (#4108)" (#4118)" (#4135)" This reverts commit 117ed20. * Disable DynamicDependency-delegate-to-OS by changing IsSupported() (not reverting the world) * PackageRuntimeManager tests rely on OS DynDep functionality but Setup was a parallel version check when it should have been IsSupported. Fixed so they're all using the same answer * Doh! Had the check reversed -- if (foo) should have been if (!foo). Fixed * Tweak TryCreatePackageDependency when calling the OS with an invaliud package family name we get back STATEREPOSITORY_E_DEPENDENCY_NOT_RESOLVED but should return to the caller E_INVALIDARG * Remove false skip-tests check. The surgical IsSupported disables all delegation to OS APIs. When that changes we WANT the tests to run and canary any problem * Bad test passing too long a VersionTag. Tweaked Bootstrapper to spew WIL message and deal instead of FAIL_FAST * Fixed PackageDependency.m_packageFullName was never set and .PackageId string fields (e.g. .name) weren't properly set, though they weren't used so not noticed or harm (before the resolution fix - next sentence...). Fixed TryCreatePackageDependency() wasn't resolving the dependency unless the MddCreatePackageDependencyOptions_DoNotVerifyDependencyResolution option was specified. Fixed up some test issues as well asupdates in sync with the fixes (above) * Fixed tests to correctly match (fixed) implementation * Improved some test logging. Fided up a few tests out of date with the latest behavior

* Revert "Revert "DynamicDependencies: Use Win11 APIs if available #3704 #4083 (#4108)" (#4118)" (#4135)" This reverts commit 117ed20. * Disable DynamicDependency-delegate-to-OS by changing IsSupported() (not reverting the world) * PackageRuntimeManager tests rely on OS DynDep functionality but Setup was a parallel version check when it should have been IsSupported. Fixed so they're all using the same answer * Doh! Had the check reversed -- if (foo) should have been if (!foo). Fixed * Tweak TryCreatePackageDependency when calling the OS with an invaliud package family name we get back STATEREPOSITORY_E_DEPENDENCY_NOT_RESOLVED but should return to the caller E_INVALIDARG * Remove false skip-tests check. The surgical IsSupported disables all delegation to OS APIs. When that changes we WANT the tests to run and canary any problem * Bad test passing too long a VersionTag. Tweaked Bootstrapper to spew WIL message and deal instead of FAIL_FAST * Fixed PackageDependency.m_packageFullName was never set and .PackageId string fields (e.g. .name) weren't properly set, though they weren't used so not noticed or harm (before the resolution fix - next sentence...). Fixed TryCreatePackageDependency() wasn't resolving the dependency unless the MddCreatePackageDependencyOptions_DoNotVerifyDependencyResolution option was specified. Fixed up some test issues as well asupdates in sync with the fixes (above) * Fixed tests to correctly match (fixed) implementation * Improved some test logging. Fided up a few tests out of date with the latest behavior Co-authored-by: Howard Kapustein <howardk@microsoft.com>

DrusTheAxe added 2 commits July 4, 2023 22:14

DynamicDependencies: Use Win11 APIs if available

46c7bba

Add new files

8c3f01a

DrusTheAxe added the area-DynamicDependencies label Jul 5, 2023

DrusTheAxe self-assigned this Jul 5, 2023

microsoft-github-policy-service bot added the needs-triage 🔍 label Jul 5, 2023

DrusTheAxe added area-Installer and removed needs-triage 🔍 labels Jul 5, 2023

DrusTheAxe added 12 commits October 26, 2023 12:57

Merge branch 'develop' into user/drustheaxe/dyndep-win11

3c93fa5

Bootstrapper compiles! Dirty hack needs cleaning up but the initial w…

4c9e0a8

…ork is done. Cleanup and test revisions needed but progress

Remove MSIXInstallFromPath - prototype/attempt to enhance VS experien…

bba32bf

…ce during early 1.x days but not moved forward and starting to age out. Removed rather than continuing upkeep

47326537: [Splash] - WinAppSDK DynamicDependency delegate to OS API w…

deb7f31

…hen available

Removed dead code

9d07d80

Closer...

0f29290

Almost...

b9618d3

More tweaks. BootstrapTests pass!

7a1d4f9

Added initial Resolve API. Fixed GetResolved*() to only query not res…

2ba55f5

…olve an unresolved PackageDependency

Added GetResolvedPackageFullNameForPackageDependency2. Fixed up tests

8df2747

Test_Win32* all pass!

5a90778

Update WinRT API to support delegating to Win11 (caveat: see GetFromI…

dfe67c6

…d()). Updated tests.

DrusTheAxe added this to the 1.5 milestone Nov 8, 2023

DrusTheAxe removed the area-Installer label Nov 8, 2023

DrusTheAxe added 2 commits November 7, 2023 18:41

Did the work to support Win11 21H2 but the OS may not fully support i…

fd837cd

…t. Left IsSupported() unchanged (Win11 >=22H2) for now while I investigate further

Merge branch 'develop' into user/drustheaxe/dyndep-win11

90d8311

DrusTheAxe added 2 commits November 8, 2023 14:00

Increase test timeout to 120m

db74f0a

Merge branch 'develop' into user/drustheaxe/dyndep-win11

8bfa7b5

Merge branch 'develop' into user/drustheaxe/dyndep-win11

1d53160

DrusTheAxe requested a review from BenJKuhn November 15, 2023 22:30

wcheng-msft reviewed Nov 27, 2023

View reviewed changes

dev/DynamicDependency/API/M.AM.DD.PackageDependency.cpp Outdated Show resolved Hide resolved

wcheng-msft reviewed Nov 27, 2023

View reviewed changes

dev/DynamicDependency/API/MsixDynamicDependency.h Outdated Show resolved Hide resolved

DrusTheAxe added 2 commits November 27, 2023 12:52

Merge branch 'main' into user/drustheaxe/dyndep-win11

2af1aab

Incorporated feedback

1b316b1

wcheng-msft approved these changes Nov 27, 2023

View reviewed changes

Merge branch 'main' into user/drustheaxe/dyndep-win11

895bfdc

Merge branch 'main' into user/drustheaxe/dyndep-win11

a5ca1d6

DrusTheAxe merged commit f0d6f3b into main Nov 30, 2023

DrusTheAxe deleted the user/drustheaxe/dyndep-win11 branch November 30, 2023 17:50

kythant added a commit that referenced this pull request Jan 22, 2024

Revert "DynamicDependencies: Use Win11 APIs if available (#3704)"

5275335

This reverts commit f0d6f3b.

kythant mentioned this pull request Jan 23, 2024

Revert "DynamicDependencies: Use Win11 APIs if available" #3704 #4083 #4108

Merged

kythant added a commit that referenced this pull request Jan 23, 2024

Revert "DynamicDependencies: Use Win11 APIs if available (#3704)"

b1efb7f

This reverts commit f0d6f3b.

kythant added a commit that referenced this pull request Jan 26, 2024

Revert "Revert "DynamicDependencies: Use Win11 APIs if available" #3704

a3f1b0b

#4083 (#4108)" This reverts commit 775edb1.

kythant added a commit that referenced this pull request Jan 26, 2024

DynamicDependencies: Use Win11 APIs if available #3704 #4083 (#4108)" (…

daf5498

…#4118) This reverts commit 775edb1.

kythant added a commit that referenced this pull request Jan 30, 2024

Revert "DynamicDependencies: Use Win11 APIs if available #3704 #4083 (#…

e4bf440

…4108)" (#4118)" This reverts commit daf5498.

kythant added a commit that referenced this pull request Jan 30, 2024

Revert "DynamicDependencies: Use Win11 APIs if available #3704 #4083 (#…

117ed20

…4108)" (#4118)" (#4135) This reverts commit daf5498.

DrusTheAxe added a commit that referenced this pull request Jan 31, 2024

Revert "Revert "DynamicDependencies: Use Win11 APIs if available #3704 …

fb81563

…#4083 (#4108)" (#4118)" (#4135)" This reverts commit 117ed20.

bpulliam mentioned this pull request Feb 7, 2024

[1.5] CP of Revert "Revert "DynamicDependencies #4171

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DynamicDependencies: Use Win11 APIs if available #3704

DynamicDependencies: Use Win11 APIs if available #3704

DrusTheAxe commented Jul 5, 2023 •

edited

Loading

DrusTheAxe commented Nov 8, 2023

azure-pipelines bot commented Nov 8, 2023

DrusTheAxe commented Nov 8, 2023

azure-pipelines bot commented Nov 8, 2023

azure-pipelines bot commented Nov 15, 2023

kythant commented Nov 21, 2023

Scottj1s commented Nov 21, 2023 via email

DrusTheAxe commented Nov 27, 2023

wcheng-msft left a comment

DrusTheAxe commented Nov 29, 2023

DrusTheAxe commented Nov 30, 2023

DynamicDependencies: Use Win11 APIs if available #3704

DynamicDependencies: Use Win11 APIs if available #3704

Conversation

DrusTheAxe commented Jul 5, 2023 • edited Loading

DrusTheAxe commented Nov 8, 2023

azure-pipelines bot commented Nov 8, 2023

DrusTheAxe commented Nov 8, 2023

azure-pipelines bot commented Nov 8, 2023

azure-pipelines bot commented Nov 15, 2023

kythant commented Nov 21, 2023

Scottj1s commented Nov 21, 2023 via email

DrusTheAxe commented Nov 27, 2023

wcheng-msft left a comment

Choose a reason for hiding this comment

DrusTheAxe commented Nov 29, 2023

DrusTheAxe commented Nov 30, 2023

DrusTheAxe commented Jul 5, 2023 •

edited

Loading