FI Main To Develop #2429
Merged
FI Main To Develop #2429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#2369) During AppNotification registration for unpackaged apps, we don't retrieve icon/displayName from window anymore. Hence, in this PR we remove the sample code used to set icon and display name using Shell APIs.
Update FrameworkUDK To 1.1.2-CI-25087.1000.220401-1608.1
…ve our own broken solution. (#2367)
…tract names didn't match or were absent) (#2375)
* Update WinRT contracts per specs\WinRT\WinRTAPIContracts.md (some contract names didn't match or were absent) * Add commit missed by previous PR
AppNotification app icon and display name can now be retrieved from the best app shortcut. This is possible by calling a FrameworkUdk API. Retrieving assets from shortcut is now the to-go approach. Current approaches to retrieve assets are now fallbacks. Verified the change with the ToastNotificationsDemoApp running as unpackaged.
* DeploymentTelemetry Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com>
Description: The current localFolderPath points to an incorrect path. Correct it to use the C:\Users\<user>\AppData\Local\Microsoft\WindowsAppSDK\ Validation: Use the DemoApp to validate if the iconPath is pointing to the right folder. Added a unittest and validated the contents of the folder.
* Update push telemetry to match toast telemetry * UnregisterAll needs to be tracked * Don;t log the same event twice Co-authored-by: Eric Langlois <erlangl@microsoft.com>
* Update branch and channels to preview * Update branch and channels to preview * Bootstrap AutoInitialize - Fix typos due to bad merge (#2368) (#2376) * Update FrameworkUDK To 1.1.2-CI-25087.1000.220401-1608.1 * Resolve issues where AppInstance.FindOrRegisterForKey("key") can return null. (#2362) (#2374) * Resolve issues where calling TrySetKey will duplicate the keyCreationMutex, preventing new instances from being created once the actual named instance has closed. * Use lock to decide what AppInstance corresponds to a key. Co-authored-by: Scott Darnell <20483794+aeloros@users.noreply.github.com> * Use .NET SDK's default inclusion support for Windows App SDK and remove our own broken solution. (#2381) * Update UDK to 1.1.2-CI-25087.1000.220401-1608.1 * Update ref branch to release/1.1-preview2 * Revert "Use .NET SDK's default inclusion support for Windows App SDK and remove our own broken solution. (#2381)" This reverts commit 045d154. * Update WindowsAppSDK-CommonVariables.yml * Update WindowsAppSDK-Versions.yml * Update WindowsAppSDK-BuildSetup-Steps.yml * Update WindowsAppSDK-CommonVariables.yml * Update WindowsAppSDK-CommonVariables.yml * revert this Co-authored-by: Johan Laanstra <jlaans@microsoft.com> Co-authored-by: Scott Darnell <20483794+aeloros@users.noreply.github.com> Co-authored-by: Rohan Palaniappan <35987549+rohanp-msft@users.noreply.github.com>
* Work in progress * Push tests working individually * Adding LRP to singleton, nits * Update PowerNotifications.vcxproj * Condensed packaged/unpackaged self contained tests * Used IsSupported flag instead * Working on it * BaseTestSuite working * Removed unused namespaces * Addressing nits * Use verify instead of throw * rename m_registered -> m_unregisteredFully * Ignored failing tests * Fix build issues * Update PushNotificationTests.vcxproj * Update AppNotification-Test-Constants.h
This reverts commit 0b58924.
|
/azp run TransportPackage-Foundation-PR |
|
No pipelines are associated with this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.