Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring PushNotification unit tests #2389

Merged
merged 16 commits into from
Apr 20, 2022

Conversation

pmpurifoy
Copy link
Contributor

This PR refactors the PushNotification unit tests to fully run inside TAEF instead of a separate test app exe. Failures are now diagnosable from TAEF output.

Copy link
Contributor

@danielayala94 danielayala94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see this change coming! 😊 Please revert the changes in PowerNotification tests and address the remaining comments in our tests.

@pmpurifoy pmpurifoy requested a review from DrusTheAxe April 13, 2022 00:30
@pmpurifoy
Copy link
Contributor Author

pmpurifoy commented Apr 13, 2022

@DrusTheAxe This PR adds the PushNotificationsLongRunningProcess to the test Singleton msix package and adds it as a default package to install in TAEF testing. Let me know if you don't want it as part of the default packages installed and we can discuss an alternative.

@danielayala94 danielayala94 added area-Notifications Toast notification, badges, Live Tiles, push notifications and removed needs-triage labels Apr 13, 2022
@pmpurifoy
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pmpurifoy
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pmpurifoy
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pmpurifoy
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@danielayala94 danielayala94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@pmpurifoy
Copy link
Contributor Author

/azp run

@pmpurifoy pmpurifoy enabled auto-merge (squash) April 19, 2022 23:18
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pmpurifoy pmpurifoy merged commit 1b59fce into main Apr 20, 2022
@pmpurifoy pmpurifoy deleted the user/purifoypaul/RefactorNotificationTests branch April 20, 2022 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Notifications Toast notification, badges, Live Tiles, push notifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants