Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PushNotificationManager SelfContained scenarios need better error code #2416

Open
pmpurifoy opened this issue Apr 18, 2022 · 0 comments
Open

PushNotificationManager SelfContained scenarios need better error code #2416

pmpurifoy opened this issue Apr 18, 2022 · 0 comments
Assignees
@pmpurifoy
Labels
area-Notifications Toast notification, badges, Live Tiles, push notifications feature proposal
Milestone
Future (backlog)

Comments

@pmpurifoy
Copy link
Contributor

Describe the bug

Currently, the PushNotificationManager APIs return E_FAIL if SelfContained scenario is not supported. A better HRESULT to use would be HRESULT_FROM_WIN32(ERROR_NOT_SUPPORTED).

From this conversation:
#2389 (comment)

Steps to reproduce the bug

In unpackaged/SelfContained environment, call into PushNotificationManager APIs and view the returned error code.

Expected behavior

No response

Screenshots

No response

NuGet package version

No response

Packaging type

No response

Windows version

No response

IDE

No response

Additional context

No response
@pmpurifoy pmpurifoy added the area-Notifications Toast notification, badges, Live Tiles, push notifications label Apr 18, 2022
@pmpurifoy pmpurifoy self-assigned this Apr 18, 2022
@pmpurifoy pmpurifoy mentioned this issue Apr 18, 2022
Merged
@BenJKuhn BenJKuhn added the bug Something isn't working label Apr 18, 2022
@robertzhou-wpn robertzhou-wpn added feature and removed bug Something isn't working labels Apr 25, 2022
@robertzhou-wpn robertzhou-wpn added this to the Future (backlog) milestone Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmpurifoy pmpurifoy

Labels
area-Notifications Toast notification, badges, Live Tiles, push notifications feature proposal
Projects
None yet
Milestone
Future (backlog)
Development

No branches or pull requests
4 participants
@BenJKuhn @pmpurifoy @codendone @robertzhou-wpn