Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert to reopening a resource #5475

Merged
merged 8 commits into from
Jan 13, 2021
Merged

fix: Revert to reopening a resource #5475

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5c8aab1
Revert to reopening a resource
Jan 8, 2021
0ca229c
Remove unused var
Jan 8, 2021
3a66dcd
Merge branch 'main' into srravich/bugfix-custom-action
srinaath Jan 8, 2021
7136716
Merge branch 'main' into srravich/bugfix-custom-action
srinaath Jan 11, 2021
2ec6c44
Merge branch 'main' into srravich/bugfix-custom-action
srinaath Jan 12, 2021
5b888ba
Merge branch 'main' into srravich/bugfix-custom-action
srinaath Jan 12, 2021
aae339a
Merge branch 'main' into srravich/bugfix-custom-action
boydc2014 Jan 13, 2021
7a59284
Merge branch 'main' into srravich/bugfix-custom-action
boydc2014 Jan 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions Composer/packages/client/src/recoilModel/dispatchers/project.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ import {
createQnAOnState,
currentProjectIdState,
filePersistenceState,
locationState,
projectMetaDataState,
settingsState,
showCreateQnAFromUrlDialogState,
Expand Down Expand Up @@ -209,19 +208,9 @@ export const projectDispatcher = () => {
navigate = true,
callback?: (projectId: string) => void
) => {
const { set, snapshot } = callbackHelpers;
const { set } = callbackHelpers;
try {
set(botOpeningState, true);
const rootBotId = await snapshot.getPromise(rootBotProjectIdSelector);

if (rootBotId) {
const rootBotLocation = await snapshot.getPromise(locationState(rootBotId));
// Reloading the same bot. No need to fetch resources again.
if (rootBotLocation === path) {
navigateToBot(callbackHelpers, rootBotId);
return;
}
}

await flushExistingTasks(callbackHelpers);
const { projectId, mainDialog } = await openRootBotAndSkillsByPath(callbackHelpers, path, storageId);
Expand Down