Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert to reopening a resource #5475

Merged
merged 8 commits into from
Jan 13, 2021
Merged

Conversation

srinaath
Copy link
Contributor

@srinaath srinaath commented Jan 8, 2021

Description

Reloading a project when opening again. Unfortunately, the project has to be reloaded to get changes that were made external to composer directly on the project folder. This is critical when custom actions are added.

Task Item

Fixes #5464

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
@coveralls
Copy link

coveralls commented Jan 8, 2021

Coverage Status

Coverage increased (+0.009%) to 54.871% when pulling 7a59284 on srravich/bugfix-custom-action into 55c9054 on main.

@boydc2014 boydc2014 self-assigned this Jan 13, 2021
@boydc2014 boydc2014 merged commit 638aac5 into main Jan 13, 2021
@boydc2014 boydc2014 deleted the srravich/bugfix-custom-action branch January 13, 2021 06:32
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* Revert to reopening a resource

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>

* Remove unused var

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>

Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com>
Co-authored-by: Dong Lei <donglei@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding C#/JS custom action issue - reloading bot project to get the action added
4 participants