Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct multiline in LG page list view #5220

Merged
merged 13 commits into from
Dec 9, 2020
Merged

fix: correct multiline in LG page list view #5220

merged 13 commits into from
Dec 9, 2020

Conversation

zhixzhan
Copy link
Contributor

@zhixzhan zhixzhan commented Dec 8, 2020 •
edited by hatpick
Loading

Description

Improve multiline exprience in LG/LU/QnA list view EditableField component, now detect \r \n \r\n to enable multiline.
Also unify single/multiple line field behavior to be

  1. Enter to submit,
  2. Shift+Enter get a new line,

Task Item

close #5207

Screenshots

Untitled1

Navigation keys

EditableField

@coveralls
Copy link

coveralls commented Dec 8, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.004%) to 55.377% when pulling ab70fa8 on zhixzhan/lg-listview-editable-filed into 286bef2 on main.

a-b-r-o-w-n
a-b-r-o-w-n previously approved these changes Dec 8, 2020
View reviewed changes
@hatpick hatpick mentioned this pull request Dec 9, 2020
Closed
@hatpick hatpick merged commit 4faf250 into main Dec 9, 2020
@hatpick hatpick deleted the zhixzhan/lg-listview-editable-filed branch December 9, 2020 07:20
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@zhixzhan @boydc2014
@cwhitten @a-b-r-o-w-n @hatpick @sorgh
fix: correct multiline in LG page list view (microsoft#5220)
519f145 
* improve multiline exprience in EditableField

* EditableField allow navigations

* minor changes

* synthetic events can do it too!

Co-authored-by: Dong Lei <donglei@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: Soroush <sorgh@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hatpick hatpick hatpick approved these changes

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n left review comments

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@cwhitten cwhitten Awaiting requested review from cwhitten

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@srinaath srinaath Awaiting requested review from srinaath

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees

@hatpick hatpick

@a-b-r-o-w-n a-b-r-o-w-n

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bot Response page, default view is difficult to edit template with multiple lines
7 participants
@zhixzhan @coveralls @hatpick @a-b-r-o-w-n @boydc2014 @cwhitten @sorgh