Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot Response page, default view is difficult to edit template with multiple lines #5207

Closed
2 of 8 tasks
mewa1024 opened this issue Dec 7, 2020 · 1 comment · Fixed by #5220
Closed
2 of 8 tasks
Assignees
Labels
Needs-triage A new issue that require triage Type: Bug Something isn't working

Comments

@mewa1024
Copy link
Contributor

mewa1024 commented Dec 7, 2020

Describe the bug

Version

v1.2.1-nightly.192397.d88f6af

Browser

  • Electron distribution
  • Chrome
  • Safari
  • Firefox
  • Edge

OS

  • macOS
  • Windows
  • Ubuntu

To Reproduce

Steps to reproduce the behavior:

  1. Go to Bot Responses.

  2. Find a template that has multiple lines (either multiple response variations or a multi-line response), and select the responses:
    image

  3. If you try to use the arrow keys to move up or down a line, you select the previous or next template instead.

Conversely, if you try to add newlines to a single-line template, it deselects the text input.
To get around this, you can edit in the "Show code" view:
image

but then if you switch back to the default view, the responses all appear on one line:
image

Expected behavior

In the default view, when a response template is selected, I'd expect to be able to use arrow keys to navigate within the field, like any text input. I'd also expect to be able use the Enter key to add new lines.

@mewa1024 mewa1024 added Type: Bug Something isn't working Needs-triage A new issue that require triage labels Dec 7, 2020
@mewa1024 mewa1024 changed the title Bot Repsonse page, default view is difficult to edit template with multiple lines Bot Response page, default view is difficult to edit template with multiple lines Dec 7, 2020
@zhixzhan zhixzhan self-assigned this Dec 8, 2020
@zhixzhan
Copy link
Contributor

zhixzhan commented Dec 8, 2020

Hi @mewa1024 , as you described above there are 3 items in this issue

  1. Unable to use arrow keys to move up/down.
    There is a fluentui issue track this bug FocusZone in DetailList component doesn't support Multiline TextField fluentui#12177

  2. Press Enter key to add a new line.
    Currently, you can Enter is submit, Shift + Enter is add a new line.

For single line switch to multi line case, you may need

  • 2.1 Shift + Enter switch current filed to multi line
  • 2.2 Click active current filed
  • 2.3 Shift + Enter add a new line
  1. multi line template is not show up as multi line.
    current detecting is template character's number, did not look for NEWLINE, I will fix it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-triage A new issue that require triage Type: Bug Something isn't working
Projects
None yet
2 participants