-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add onOpenDialog
api to support dialog jump
#4542
Conversation
onOpenDialog
api to support goto dialogonOpenDialog
api to support dialog jump
This looks reasonable to me for creating a dedicated api in this BeginDialog jump. My question is should we just update the logic to use this new API, so that we will know how much changes is needed or what the impact is. That will help us to determine whether take this or not, right? |
@boydc2014 The new API is consumed in |
Oh, get it |
@yeze322 can you address conflicts |
@yeze322 still have conflicts |
* impl onOpenDialog as DialogEditingContext * add missing api in stub Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Dong Lei <donglei@microsoft.com>
Description
closes #3942
Previously, we use
navTo()
to support both breadcrumb jump and BeginDialog jump. It has several problemsnavTo
api broke the dialog jump behavior, we fixed this bug.navTo()
API belongs toApplicationContextApi
while Flow Editor prefers to consumeDialogEditingContextApi
. UsingnavTo
breaks the context boundary.For providing a more descriptive interface, this PR implements the new api
onOpenDialog
used only in the dialog jump scenario. In the future, we can freely update thenavTo()
api without bothering breaking the dialog jump behavior.Task Item
Screenshots