Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a new navigation API to handle jumping between dialogs #3942

Closed
8 tasks
yeze322 opened this issue Aug 31, 2020 · 0 comments · Fixed by #4542
Closed
8 tasks

Create a new navigation API to handle jumping between dialogs #3942

yeze322 opened this issue Aug 31, 2020 · 0 comments · Fixed by #4542
Assignees
@yeze322
Labels
P1 Painful if we don't fix, won't block releasing Team: Platform Type: Engineering
Milestone
R11

Comments

@yeze322
Copy link
Contributor

yeze322 commented Aug 31, 2020

Describe the bug

When fixing breadcrumb and navigation behavior, jumping between dialogs by clicikng on BeginDialog was broken silently.
We need a standalone dialog jump API to treat this scenario specially and as an anti-corruption layer.

Version

Browser

  • Electron distribution
  • Chrome
  • Safari
  • Firefox
  • Edge

OS

  • macOS
  • Windows
  • Ubuntu

To Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

Screenshots

Additional context
@yeze322 yeze322 added Type: Engineering R11 Release 11 - November 15th, 2020 labels Aug 31, 2020
@cwhitten cwhitten added this to the R11 milestone Sep 3, 2020
@cwhitten cwhitten added Team: Platform P1 Painful if we don't fix, won't block releasing and removed R11 Release 11 - November 15th, 2020 labels Oct 1, 2020
@yeze322 yeze322 mentioned this issue Oct 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yeze322 yeze322

Labels
P1 Painful if we don't fix, won't block releasing Team: Platform Type: Engineering
Projects
None yet
Milestone
R11
Development

Successfully merging a pull request may close this issue.

chore: add onOpenDialog api to support dialog jump yeze322/BotFramework-Composer
3 participants
@cwhitten @yeze322 @lei9444