Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improved Electron auto update UX #2925

Merged
merged 4 commits into from
May 6, 2020
Merged

fix: Improved Electron auto update UX #2925

merged 4 commits into from
May 6, 2020

Conversation

tonyanziano
Copy link
Contributor

Description

This PR contains several improvements to the Electron auto update UX:

  • Setup infrastructure to properly switch between update channels (stable / nightly)
    • note: A follow-up PR will be coming to allow users to switch this via the UI
  • Added a menu item to the "Help" menu that allows the user to explicitly check for updates
  • Fixed a missing hooks dependency that was preventing the error dialog from properly displaying auto update errors

Task Item

Fixes #2226

Screenshots

New menu item

image

Using the explicit menu item

https://recordit.co/VzHkpmIxn2

Error dialog before fix:

error-dialog-before

Error dialog after fix:

error-dialog-after

@github-actions
Copy link

github-actions bot commented May 6, 2020

Coverage Status

Coverage remained the same at 0.0% when pulling d3312a0 on toanzian/update-fix into e65569b on master.

@cwhitten cwhitten merged commit 2386ae3 into master May 6, 2020
@cwhitten cwhitten deleted the toanzian/update-fix branch May 6, 2020 18:46
alanlong9278 added a commit that referenced this pull request May 7, 2020
* master: (58 commits)
  fix: Copy skill manifests to the correct directory in the localPublish plugin (#2932)
  feat: Goto Begin Dialog after clicking dialog (#2922)
  fix: Improved Electron auto update UX (#2925)
  fix: Action Flow gradual left alignment (#2909)
  fix: word wrap in SendActivity (#2908)
  fix: Fixed various onboarding issues and updated content (#2900)
  chore: Component Governance (#2899)
  perf: improve property editor performance (#2921)
  fix: paste blank node (#2905)
  extract memory variables at lg lsp server (#2902)
  feat: manage samples via plugin (#2805)
  can not use event capture in visual editor (#2913)
  style: make focus styles more consistent (#2898)
  feat: azure publish plugin (#2733)
  fix: unable to clear form title (#2885)
  fix: Populate env variable with AppData folder (#2894)
  a11y: use Key/Value aria labels in object field (#2890)
  Fix border issue in visual editor (#2891)
  fix: changes manifest type from '.manifest' to '.json' (#2888)
  Fixed packaged folder structure. (#2887)
  ...
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* More auto update polish.

* Added more tests.

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants