Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed various onboarding issues and updated content #2900

Merged
merged 5 commits into from
May 6, 2020
Merged

fix: Fixed various onboarding issues and updated content #2900

merged 5 commits into from
May 6, 2020

Conversation

tdurnford
Copy link
Collaborator

Description

  • Corrected the teaching bubble positioning on the homepage and in the Visual Editor
  • Updated the Visual Editor to use the addCoachMarkRef from the shellApi instead of plumbing the method through the editor - I love hooks
  • Set the default state to enabled for new installations of Composer
  • Updated some of the teaching bubbles to reflect the changes made to Composer

Task Item

Closes #2790

@coveralls
Copy link

coveralls commented May 6, 2020

Coverage Status

Coverage remained the same at 0.0% when pulling 1b490c1 on tdurnford:fix/onboarding into 43b993a on microsoft:master.

@cwhitten cwhitten merged commit 558372f into microsoft:master May 6, 2020
@tdurnford tdurnford deleted the fix/onboarding branch May 6, 2020 16:18
alanlong9278 added a commit that referenced this pull request May 7, 2020
* master: (58 commits)
  fix: Copy skill manifests to the correct directory in the localPublish plugin (#2932)
  feat: Goto Begin Dialog after clicking dialog (#2922)
  fix: Improved Electron auto update UX (#2925)
  fix: Action Flow gradual left alignment (#2909)
  fix: word wrap in SendActivity (#2908)
  fix: Fixed various onboarding issues and updated content (#2900)
  chore: Component Governance (#2899)
  perf: improve property editor performance (#2921)
  fix: paste blank node (#2905)
  extract memory variables at lg lsp server (#2902)
  feat: manage samples via plugin (#2805)
  can not use event capture in visual editor (#2913)
  style: make focus styles more consistent (#2898)
  feat: azure publish plugin (#2733)
  fix: unable to clear form title (#2885)
  fix: Populate env variable with AppData folder (#2894)
  a11y: use Key/Value aria labels in object field (#2890)
  Fix border issue in visual editor (#2891)
  fix: changes manifest type from '.manifest' to '.json' (#2888)
  Fixed packaged folder structure. (#2887)
  ...
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
)

* fix: Fixed various onboarding issues and updated content

* fixed integration tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants