Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update BotProject.csproj 4.9.0-preview.200427-125093 #2803

Merged
merged 2 commits into from
Apr 28, 2020
Merged

fix: Update BotProject.csproj 4.9.0-preview.200427-125093 #2803

merged 2 commits into from
Apr 28, 2020

Conversation

luhan2017
Copy link
Contributor

Description

Update the sdk package to 4.9.0-preview.200427-125093 which brings in the empty lg file fix.

Task Item

fixes #2802

Screenshots

@luhan2017 luhan2017 requested a review from boydc2014 as a code owner April 28, 2020 09:35
@github-actions
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 0561807 on luhan/packageUpdate into ac1e959 on master.

@a-b-r-o-w-n a-b-r-o-w-n merged commit 698561d into master Apr 28, 2020
@a-b-r-o-w-n a-b-r-o-w-n deleted the luhan/packageUpdate branch April 28, 2020 20:16
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request May 15, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@luhan2017 @cwhitten
fix: do not cause runtime error for bots with empty lg files (microso…
cd8f6db 
…ft#2803)

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhitten cwhitten cwhitten approved these changes

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luhan2017 @cwhitten @a-b-r-o-w-n