a11y: use useShell for global announcements #2734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-b-r-o-w-n
requested changes
Apr 22, 2020
Composer/packages/client/src/pages/language-generation/table-view.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/adaptive-form/src/components/fields/ObjectArrayField.tsx
Outdated
Show resolved
Hide resolved
a-b-r-o-w-n
approved these changes
Apr 22, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* start using useShell for announcements * fix crashing issue * Update ObjectArrayField.tsx * Update ObjectArrayField.tsx * fixes from PR Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This uses the useShell mechanism to make the "announce" action easier to introduce various places in the code, including inside extensions like the adaptive form editor.
Task Item
closes #2130