Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility][Object Information - Property Pane_Connect to QnA Knowledgebase]: No info is provided for the 'Enter' button to perform action. #2130

Closed
ashish315 opened this issue Feb 28, 2020 · 9 comments

Comments

@ashish315
Copy link

ashish315 commented Feb 28, 2020

User Experience
The screen reader user will get confused if the proper information is not announced by the narrator.

Test Environment
Browser: Microsoft Edge Canary Version: 82.0.425.0 (Official build)
OS build: 2004 (19564.1005)
Screen Reader: Narrator
URL: Bot Framework Composer
Prerequisite Here

Repro Steps:

  1. Open the above mentioned URL in EDGE and turn on narrator.
  2. Navigate to already created dialog tree item and activate it. Such as- Greetings, Actions, EndDialog etc.
  3. Click on "+" and select 'Access External resources'. Then select 'Connect to QnA Knowledgebase' from the available options.
  4. Navigate to edit fields under "Strict Filters' having functionality to enter.
  5. Observer the issue in Property Pane.

Actual:
The screen reader didn't announce any information about the functionality of 'Enter' to insert the data. Same issue found for the 'Value and Name' edit field.
Narrator only narrates the placeholder whereas the edit fields have functionality that if user press 'Enter' the data gets inserted.

Expected:
The narrator should announce the functionality of 'Enter'. It should announce as 'Press Enter to insert name or press tab to move the cursor on the next interactive element'.
Similarly for value edit field 'Press Enter to insert value or press tab to move the cursor on the next interactive element'.

Note:
Issue is observed for all the Property Pane which have similar control such as 'Property Pane_Ask a question (Other)'.

MAS Impacted: MAS4.2.1

Attachment:
No info is provided for the 'Enter' button to perform action.zip
Narrator should announce the functionality of Enter Key

@corinagum
Copy link
Contributor

@ashish315 just FYI, looks like the attachment didn't make it onto this issue. :)

@cwhitten cwhitten removed the Needs-triage A new issue that require triage label Feb 29, 2020
@ashish315
Copy link
Author

@corinagum The attachments are updated now.

@ashish315
Copy link
Author

@beyackle As checked on below environment the issue is still repro.

Issue repro at-

  1. "Validation rules" edit field at 'Property Pane_Ask a question (Other tab)'.
  2. "Name" edit field at 'Property Pane_Connect to QnA Knowledgebase'.

Test Environment
Browser: Microsoft Edge Dev {Version 83.0.467.0 (Official build) dev (64-bit)}
Browser: Microsoft Edge Canary {Version 83.0.474.0 (Official build) canary (64-bit)}
OS build: 2004 (19588.1000)
Screen Reader: Narrator
URL: Bot Framework Composer
Prerequisite Here

@ashish315 ashish315 removed the Fixed label Apr 4, 2020
@corinagum
Copy link
Contributor

As I understand the filed issue, I am seeing this as fixed. (I have a small nit, detailed below)

@ashish315 In reference to your repro steps above ("Validation rules..."), could you provide a video of this behavior?

image
Instead of field, should this say something like 'to advance to the value input'?

@ashish315
Copy link
Author

The narrator should announce 'Press Enter to insert name' while the focus is at name edit field.
Please look into the attached video:
Regress 2130.zip

@beyackle
Copy link
Contributor

beyackle commented Apr 9, 2020

I'll handle this. It's just a message change.

@beyackle beyackle added the Fixed label Apr 14, 2020
@ashish315
Copy link
Author

@beyackle As checked and verified on below environment, the issue is not fixed. I downloaded below Master build file last updated on 18th April.

Test Environment
Browser: Microsoft Edge Dev {Version 83.0.467.0 (Official build) dev (64-bit)}
OS build: 2004 (19588.1000)
Screen Reader: Narrator
URL: Bot Framework Composer
Prerequisite Here
image

@ashish315 ashish315 removed the Fixed label Apr 20, 2020
@beyackle
Copy link
Contributor

Okay, I've gone back and double-checked this, and while it does correctly read the caption when the field is entered, there's still a minor bug where entering a name into the first part of an object field and then hitting Enter without entering a value will advance to a new row (as intended), but then the SR reads nothing out for the new row. So while this issue is mostly fixed, that one bug still remains.

@ashish315
Copy link
Author

As checked the issue is fixed now, so HCL is closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants