Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y: add linkBtn to tab-order #2717

Merged
merged 7 commits into from
Apr 23, 2020
Merged

a11y: add linkBtn to tab-order #2717

merged 7 commits into from
Apr 23, 2020

Conversation

alanlong9278
Copy link
Contributor

Description

Add dialog's linkBtn to tab-order in visual editor.

Task Item

fix #2062

Screenshots

tabcheck

@alanlong9278 alanlong9278 changed the base branch from stable to master April 20, 2020 11:25
@github-actions
Copy link

Coverage Status

Coverage decreased (-0.06%) to 40.66% when pulling efdaa38 on julong/linkToTabOrder into 3558910 on master.

Copy link
Contributor

@beyackle beyackle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwhitten cwhitten merged commit 3d94f1c into master Apr 23, 2020
@cwhitten cwhitten deleted the julong/linkToTabOrder branch April 23, 2020 19:54
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* add inline link to tab order

* refactor code

Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Accessibility][Keyboard - Actions]: 'Action' Button available under the node is not accessible by keyboard.
3 participants