Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility][Keyboard - Actions]: 'Action' Button available under the node is not accessible by keyboard. #2062

Closed
ashish315 opened this issue Feb 23, 2020 · 7 comments · Fixed by #2717

Comments

@ashish315
Copy link

ashish315 commented Feb 23, 2020

User Experience:
Keyboard dependent users will not be able to use the functionality of the control if the any control is not accessible via keyboard.

Test Environment
Browser: Microsoft Edge Canary Version: 82.0.425.0 (Official build)
OS build: 2004 (19564.1005)
Screen Reader: Narrator
URL: Bot Framework Composer
Prerequisite Here

Repro Steps:

  1. Open the above mentioned URL in EDGE
  2. "Bot Framework Composer" homepage will gets opened.
  3. Select "Dialog Actions" from the available Bots under 'Examples' and activate it.
  4. Navigate the dialog 'Define conversation objective' then press 'Next'.
  5. Navigate to already created dialog tree item and activate it. Such as- Greetings, Actions, EndDialog etc.
  6. Now, the tree structure appears in the centre. Navigate to already created node.
  7. Activate the 'Actions' button available below the name of the node.
  8. Observe the issue.

Actual:
"Action" button is not accessible by keyboard. On using mouse, the control are interactive as action is getting performed but its not accessible with keyboard.

Note:
Same issue observed with other button's which are present in the node similar to action button's such button's are in "Replacedialog" pane.

Expected:
The controls which are accessible with mouse must be accessible with keyboard. So, 'Action' button must be accessible with keyboard.

MAS Impacted: MAS2.1.1

Attachment:
MAS2.1.1_Action is not accesible with keyboard.zip

@alanlong9278
Copy link
Contributor

@ashish315 @cwhitten Keyboard move track logic is that we can move cursor between the whole node, nodeMenu and edgeMenu, so "Action" button is not accessible by keyboard because Action button is a part of step node, we can not move cursor into it with keyboard.

@cwhitten
Copy link
Member

cwhitten commented Apr 15, 2020

Need to update BeginDialog and ReplaceDialog to add the dialogRef into the tab-order.

@ashish315
Copy link
Author

@cwhitten As checked, still action button and other button's {that are like action button in the other nodes such as in replacedialog} are not accessible with keyboard.

@ashish315 ashish315 removed the Fixed label Apr 23, 2020
@cwhitten
Copy link
Member

@ashish315 please attach screenshots of what you refer to as "Action button" and "other buttons:

@ashish315
Copy link
Author

Screenshots:

image
image
image

@alanlong9278
Copy link
Contributor

alanlong9278 commented Apr 24, 2020

I checked it. (Dialog) isn't the part of the Action button link. The link content is just actions, so we can not focus in the whole content actions(Dialog). @ashish315
image

@ashish315
Copy link
Author

Agree with @alanlong9278 So HCL is closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants