chore: [not target master] rename 'uiSchema' in PluginConfig to 'formSchema' #2634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-b-r-o-w-n
approved these changes
Apr 14, 2020
cwhitten
pushed a commit
that referenced
this pull request
Apr 14, 2020
* rename 'ui:widget' field to 'widget' * change default widget to ActionHeader * fix visual editor demo * simplify visual schema * support loading widgets via reflection * uischema -> visualSchema * drive TypesWithoutWrapper as 'nowrap' in schema * remove outdated files * hoists visualSchema.types to @bfc/extension * rename visualSchema to defaultVisualSchema * fix demo * consume Extension context in Visual * declare schema as Visual Props * let visual editor consume plugin schema * split visual config to widgets & schema * implement visual plugin merge strategy * migrate SendActivity to Lg plugin * move styled components to external lib * move prompts visual schema to 'prompts' plugin * rename @visual-designer-elements to @ui-shared * use ui-shared in LG * fix visual widget type declaration * add missing workspace dependency * remove ActivityRenderer (replaced by LgWidget) * remove unref vars * rename: visualSchema -> flowSchema * update config key to `visualSchema` * chore: rename 'uiSchema' in PluginConfig to 'formSchema' (#2634) * PluginConfig.uiSchema ->formSchema * fix alphabetical issue in test
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* rename 'ui:widget' field to 'widget' * change default widget to ActionHeader * fix visual editor demo * simplify visual schema * support loading widgets via reflection * uischema -> visualSchema * drive TypesWithoutWrapper as 'nowrap' in schema * remove outdated files * hoists visualSchema.types to @bfc/extension * rename visualSchema to defaultVisualSchema * fix demo * consume Extension context in Visual * declare schema as Visual Props * let visual editor consume plugin schema * split visual config to widgets & schema * implement visual plugin merge strategy * migrate SendActivity to Lg plugin * move styled components to external lib * move prompts visual schema to 'prompts' plugin * rename @visual-designer-elements to @ui-shared * use ui-shared in LG * fix visual widget type declaration * add missing workspace dependency * remove ActivityRenderer (replaced by LgWidget) * remove unref vars * rename: visualSchema -> flowSchema * update config key to `visualSchema` * chore: rename 'uiSchema' in PluginConfig to 'formSchema' (microsoft#2634) * PluginConfig.uiSchema ->formSchema * fix alphabetical issue in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this PR, ui plugins will use
formSchema+flowSchemaconvention instead of a generic config nameuischema.@a-b-r-o-w-n I only touched the PluginConfig layer, didn't rename all
UISchema/UiSchemaappearances in AdaptiveForm deeply. As an example, I renamedextension/src/types/uiSchema.tstoformSchemato make sure it's consistent withflowSchema, but I didn't rename those type definitionsUISchema/UIOptionsto avoid too much semantic changes in AdaptiveForm.Task Item
Screenshots