feat: Visual Editor as an extension #2586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwhitten
reviewed
Apr 13, 2020
| @@ -6,6 +6,7 @@ import { PluginConfig } from '@bfc/extension'; | |||
|
|
|||
| const PluginContext = React.createContext<Required<PluginConfig>>({ | |||
| uiSchema: {}, | |||
| visual: {}, | |||
There was a problem hiding this comment.
these names here are odd. uiSchema ? visual ? Questions I have as a developer using this interface:
- What's the difference?
uiSchemacorresponds to forms andvisualcorresponds to the flow editor? Not very self-descriptive. - Why the need for both?
There was a problem hiding this comment.
What do you think would be most intuitive?
I think making a change like make sense.
interface uiSchema {
formSchema: FormSchema;
flowSchema: FlowSchema;
}There was a problem hiding this comment.
LGTM. @yeze322 can you make this change?
There was a problem hiding this comment.
@a-b-r-o-w-n @cwhitten Great! It's a good name, I will update it
There was a problem hiding this comment.
visual renamed to flowSchema, renamed uiSchema to formSchema in a separated PR #2634
|
renamed |
* PluginConfig.uiSchema ->formSchema * fix alphabetical issue in test
cwhitten
approved these changes
Apr 14, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* rename 'ui:widget' field to 'widget' * change default widget to ActionHeader * fix visual editor demo * simplify visual schema * support loading widgets via reflection * uischema -> visualSchema * drive TypesWithoutWrapper as 'nowrap' in schema * remove outdated files * hoists visualSchema.types to @bfc/extension * rename visualSchema to defaultVisualSchema * fix demo * consume Extension context in Visual * declare schema as Visual Props * let visual editor consume plugin schema * split visual config to widgets & schema * implement visual plugin merge strategy * migrate SendActivity to Lg plugin * move styled components to external lib * move prompts visual schema to 'prompts' plugin * rename @visual-designer-elements to @ui-shared * use ui-shared in LG * fix visual widget type declaration * add missing workspace dependency * remove ActivityRenderer (replaced by LgWidget) * remove unref vars * rename: visualSchema -> flowSchema * update config key to `visualSchema` * chore: rename 'uiSchema' in PluginConfig to 'formSchema' (microsoft#2634) * PluginConfig.uiSchema ->formSchema * fix alphabetical issue in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apply the extension pattern to Visual Editor
fix #2120
Extension pattern's impact on Visual Editor
Visual Editor received verbose props before, now it consumes Extension context.
Visual Editor didn't support plugin before, now it supports plugin so we can put complicated $kinds out of visual's core lib.
Visual Editor's uischema (visualSchema) only supported direct import React Component before, now it supports register a widget and consume it by string.
Main changes
uiSchemaXXX->visualSchemaXXXSendActivity-> plugin/lg,TextInput/ChoiceInput... -> plugin/prompts)@bfc/ui-sharedlib to share ui elements between Visual Editor and plugins (shared as a design language)Plugin schema that Visual Editor supports
Visual Editor requires two parts of config -- widgets and schema
As an example, in
plugins/lg, it declares a widget named 'LgWidget' and register the visual node definition ofMicrosoft.SendActivity.Task Item
closes #2120
Screenshots