feat: Rewrite suggestions and diagnostics in LG LSP with latest LG APIs #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhixzhan
reviewed
Mar 10, 2020
Composer/packages/tools/language-servers/language-generation/src/LGServer.ts
Outdated
Show resolved
Hide resolved
Composer/packages/tools/language-servers/language-generation/src/LGServer.ts
Outdated
Show resolved
Hide resolved
Composer/packages/tools/language-servers/language-generation/src/LGServer.ts
Outdated
Show resolved
Hide resolved
…ework-Composer into shuwan/refactor-lg-lsp
yeze322
reviewed
Mar 18, 2020
Composer/packages/server/assets/projects/ActionsSample/ComposerDialogs/Actions/Actions.dialog
Outdated
Show resolved
Hide resolved
7 tasks
cwhitten
approved these changes
Mar 24, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…Is (microsoft#2208) * init * fix importResolver * fix templates suggestions * fix return * fix get all templates method * fix comments * fix test cases * upgrade lgParser related api * fix * revert designIds * revert designIds * upgrade lg api change Co-authored-by: zhixzhan <zhixzhan@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2211
Implement completion and validate functions with latest LG APIs.
Now templates and diagonsitc are managed under LGFile class.
Indexer for LG editor also has been modified. Replace statichecker with LGParser.