Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lg inline editor swallow characters #2152

Closed
1 of 7 tasks
alanlong9278 opened this issue Mar 3, 2020 · 4 comments
Closed
1 of 7 tasks

lg inline editor swallow characters #2152

alanlong9278 opened this issue Mar 3, 2020 · 4 comments
Assignees
@zhixzhan
Labels
R9 Release 9 - May 15th, 2020 Type: Bug Something isn't working

Comments

@alanlong9278
Copy link
Contributor

alanlong9278 commented Mar 3, 2020 •
edited
Loading

Describe the bug

lg inline editor swallow characters if inputing comments.

Version

Browser

  • Chrome
  • Safari
  • Firefox
  • Edge

OS

  • macOS
  • Windows
  • Ubuntu

To Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

Screenshots

lg

Additional context
@alanlong9278 alanlong9278 added the Needs-triage A new issue that require triage label Mar 3, 2020
@zhixzhan zhixzhan assigned zhixzhan and unassigned Danieladu Mar 3, 2020
@hibrenda hibrenda added Type: Bug Something isn't working and removed Needs-triage A new issue that require triage labels Mar 3, 2020
@zhixzhan
Copy link
Contributor

zhixzhan commented Mar 5, 2020

The issue is lg parser do not include comments to this template body correctly, reported to LG team, I guess it would be fixed soon.

@cwhitten
Copy link
Member

@zhixzhan will the LG team be fixing this? Can you reference an issue if so?

@zhixzhan
Copy link
Contributor

zhixzhan commented Mar 23, 2020 •
edited
Loading

@cwhitten Yes, they already fixed it at microsoft/botbuilder-js#1849, I will integrate it later( after #2208 avoid conflicts if they both modify lg api )

@zhixzhan zhixzhan mentioned this issue Mar 26, 2020
Merged
@hibrenda hibrenda added the R9 Release 9 - May 15th, 2020 label Mar 26, 2020
@cwhitten
Copy link
Member

cwhitten commented Apr 7, 2020

addressed via #2373

@cwhitten cwhitten closed this as completed Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhixzhan zhixzhan

Labels
R9 Release 9 - May 15th, 2020 Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@cwhitten @alanlong9278 @Danieladu @hibrenda @zhixzhan