Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Destructor in shared lib for removing LG templates during node deletion (#1213) #1580

Merged
merged 17 commits into from
Nov 19, 2019
Merged

chore: Destructor in shared lib for removing LG templates during node deletion (#1213) #1580

merged 17 commits into from
Nov 19, 2019

Conversation

yeze322
Copy link
Contributor

@yeze322 yeze322 commented Nov 14, 2019 •
edited by cwhitten
Loading

Description

Implement 'destructor' in shared lib by following the same pattern with 'Copy Constructor'

Task Item

closes #1213

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code refactor (non-breaking change which improve code quality, clean up, add tests, etc)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Doc update (document update)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have functionally tested my change

Screenshots

Please include screenshots or gifs if your PR include UX changes.

@yeze322 yeze322 changed the title chore: Destructor in shared lib to remove LG resources during node deletion chore: Destructor in shared lib for removing LG templates during node deletion Nov 15, 2019
@yeze322 yeze322 mentioned this pull request Nov 15, 2019
Closed
@cwhitten cwhitten changed the title chore: Destructor in shared lib for removing LG templates during node deletion chore: Destructor in shared lib for removing LG templates during node deletion (#1213) Nov 15, 2019
cwhitten
cwhitten previously requested changes Nov 16, 2019
View reviewed changes
Copy link
Member

@cwhitten cwhitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a CI failure

@yeze322
Copy link
Contributor Author

yeze322 commented Nov 18, 2019

there's a CI failure

Fixed those broken test cases

@yeze322
Copy link
Contributor Author

yeze322 commented Nov 19, 2019

resolves the CI failure

@cwhitten cwhitten merged commit aa4ce70 into microsoft:master Nov 19, 2019
@yeze322 yeze322 mentioned this pull request Nov 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhitten cwhitten cwhitten approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yeze322 @cwhitten