Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete multi-selected nodes won't clean LG resources #1213

Closed
yeze322 opened this issue Oct 23, 2019 · 3 comments
Closed

Delete multi-selected nodes won't clean LG resources #1213

yeze322 opened this issue Oct 23, 2019 · 3 comments
Assignees
@yeze322
Labels
Area: Shell P0 Must Fix. Release-blocker R7 Release 7 - December 10th, 2019 Type: Bug Something isn't working

Comments

@yeze322
Copy link
Contributor

yeze322 commented Oct 23, 2019 •
edited
Loading

Version

57baf4c

Describe the bug

Using the 'Delete' button in single click can delete LG resources, however, using multi-selection to select nodes and deleting them won't clean LG resources.

Related to #922 (parent)

To Reproduce

Steps to reproduce the behavior:

  1. create two SendActivity actions, input something
  2. drag select them
  3. click Delete in toolbar
  4. common.lg not cleaned

Expected behavior

Should be deleted

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.
@yeze322 yeze322 added Needs-triage A new issue that require triage Area: Visual editor and removed Needs-triage A new issue that require triage labels Oct 23, 2019
@hibrenda hibrenda added Area: Shell Needs-triage A new issue that require triage Type: Bug Something isn't working and removed Area: Visual editor Needs-triage A new issue that require triage labels Oct 23, 2019
@hibrenda hibrenda added the R7 Release 7 - December 10th, 2019 label Oct 23, 2019
@yeze322 yeze322 self-assigned this Oct 23, 2019
@yeze322 yeze322 mentioned this issue Oct 23, 2019
Closed
@yeze322 yeze322 mentioned this issue Nov 4, 2019
Closed
9 tasks
@yeze322 yeze322 mentioned this issue Nov 6, 2019
Merged
7 tasks
@cwhitten cwhitten added the P0 Must Fix. Release-blocker label Nov 6, 2019
@yeze322
Copy link
Contributor Author

yeze322 commented Nov 7, 2019

pending on #1512

This was referenced Nov 14, 2019
Closed
Merged
@yeze322
Copy link
Contributor Author

yeze322 commented Nov 15, 2019

in pr #1580

cwhitten pushed a commit that referenced this issue Nov 19, 2019
@yeze322 @cwhitten
chore: Destructor in shared lib for removing LG templates during node…
aa4ce70 
… deletion (#1213) (#1580)

* implement adaptive action walker

* implement `deleteAction`

* add a batch api `deleteActions`

* apply new destructor to ObiEditor

* fix walkAdaptiveAction && add UT

* add test for walkAdaptiveActionList

* normalize lg templates before removing

* Update jsonTracker.ts

* move deleteAction bindings outside jsonTracker to not break origin tests

* avoid unnecessary change

* remove unused code
@cwhitten
Copy link
Member

addressed in #1580

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yeze322 yeze322

Labels
Area: Shell P0 Must Fix. Release-blocker R7 Release 7 - December 10th, 2019 Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cwhitten @yeze322 @hibrenda @zhixzhan