Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix error with puppeteer, agent can be undefined #407

Merged
merged 1 commit into from
Jun 27, 2018
Merged

fix: Fix error with puppeteer, agent can be undefined #407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion AutoCollection/HttpDependencyParser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ class HttpDependencyParser extends RequestParser {
}

// Mix in default values used by http.request and others
options.protocol = options.protocol || (<any>request).agent.protocol;
options.protocol = options.protocol || ((<any>request).agent && (<any>request).agent.protocol) || undefined;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be clear, this doesn't do anything about protocol being undefined right? But rather if agent doesn't exist?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s right

options.hostname = options.hostname || 'localhost';

return url.format(options);
Expand Down