fix: Fix error with puppeteer, agent can be undefined #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -139,7 +139,7 @@ class HttpDependencyParser extends RequestParser { | |||
| } | |||
|
|
|||
| // Mix in default values used by http.request and others | |||
| options.protocol = options.protocol || (<any>request).agent.protocol; | |||
| options.protocol = options.protocol || ((<any>request).agent && (<any>request).agent.protocol) || undefined; | |||
There was a problem hiding this comment.
Just to be clear, this doesn't do anything about protocol being undefined right? But rather if agent doesn't exist?
OsvaldoRosado
approved these changes
Jun 26, 2018
|
Thanks for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue #406
When puppeteer start, the protocol and agent can be undefined.