Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix simPause for Car #4175

Merged
merged 3 commits into from
Dec 8, 2021
Merged

Fix simPause for Car #4175

merged 3 commits into from
Dec 8, 2021

Conversation

rajat2004
Copy link
Contributor

@rajat2004 rajat2004 commented Nov 21, 2021

Fixes: #4174

About

Fixes the simPause API for Car by using UGamePlayStatistics::SetGamePaused (probably missed in #2292). And some refactoring

How Has This Been Tested?

Using the script given in #4174 (thanks to @suresh-guttikonda!) -
Before fix using 1.6.0 release -

Connected!
Client Ver:1 (Min Req: 1), Server Ver:1 (Min Req: 1)

Before pause: -1.5656204223632812, 0.7037484645843506, 0.998582124710083
After pause: -1.824690818786621, 0.8202106952667236, 0.9985887110233307

After fix -

Connected!
Client Ver:1 (Min Req: 1), Server Ver:1 (Min Req: 1)

Before pause position: <Vector3r> {   'x_val': -8.31222915649414,
    'y_val': -0.0024077333509922028,
    'z_val': 0.2384161353111267}
Before pause diff: -1.7417960166931152, -0.00044455076567828655, 0.9980698227882385
After pause position: <Vector3r> {   'x_val': -8.31222915649414,
    'y_val': -0.0024077333509922028,
    'z_val': 0.2384161353111267}
After pause: -1.7417960166931152, -0.00044455076567828655, 0.9980698227882385

Screenshots (if appropriate):

Remove unused args and members
@zimmy87
Copy link
Contributor

zimmy87 commented Dec 8, 2021

Tested this locally and it works for me, so I am merging this. Thanks for the contribution @rajat2004!

@zimmy87 zimmy87 merged commit 228f21c into microsoft:master Dec 8, 2021
@rajat2004 rajat2004 deleted the simpause branch December 8, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SimPause() not pausing physics
2 participants