Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Recording to multiple vehicles #2847

Closed
wants to merge 12 commits into from

Conversation

rajat2004
Copy link
Contributor

@rajat2004 rajat2004 commented Jul 11, 2020

New Additions -

  1. Info of all vehicles is recorded (with additional column VehicleName), VehicleName parameter in Cameras field to specify specfic vehcile to use the camera from
  2. Folder field in settings to change the directory to store data in

Example settings -

{
    "SettingsVersion": 1.2,
    "SimMode": "Car",

    "Vehicles": {
        "Car1": {
          "VehicleType": "PhysXCar",
          "AutoCreate": true
        },
        "Car2": {
          "VehicleType": "PhysXCar",
          "AutoCreate": true,
          "X": 0, "Y": 10, "Z": 0
        }
    },
    "Recording": {
        "RecordOnMove": false,
        "RecordInterval": 1,
        "Cameras": [
            { "CameraName": "0", "ImageType": 0, "PixelsAsFloat": false, "VehicleName": "Car1", "Compress": true },
            { "CameraName": "0", "ImageType": 5, "PixelsAsFloat": false, "VehicleName": "Car1", "Compress": true },
            { "CameraName": "0", "ImageType": 0, "PixelsAsFloat": false, "VehicleName": "Car2", "Compress": true }
        ]
    }

}

Recording - 2020-07-11-11-48-51.zip

Testing -

  • Multiple Vehicles, with no recording settings (Scene image from each vehicle)
  • Multiple Vehicles, specific sensor settings (Settings above)
  • Single vehicle, no settings (Scene from that vehicle, former behaviour)

TODO:

  • Update docs
  • Unity implementation

Further possible additions -

  • Allow user to specify directory to store recordings in (Replacement for Documents)
  • Currently saving no images is not possible (For some reason this leads to an error in writing to file, even though the file has been created, and there are lines in it already)
    - I suspect this might be a race condition for the first write, since there are no images, no rendering and saving of images is required, so writing of pose data is happening almost instantaneously, but the file to write the data in hasn't still been created.(Haven't confirmed this though, just a thought)

Any testing (especially of Folder on Windows) or suggestions would be great!

Came to mind when working on #2841
Related older issue #1346, Also includes the fix proposed in #1414

@rajat2004 rajat2004 force-pushed the multi-vehicle-recording branch 3 times, most recently from a34c6bd to df1ab03 Compare July 18, 2020 08:13
Sai Vemprala and others added 12 commits July 18, 2020 13:44
* Reduced warning level in Unity build

* Pr/2672 (#1)

* [Unity] Reduce build warnings

Change -Weverything to -Wextra

* [Travis] Simplify Unity build command

* [Unity] Fix missing override warnings

Co-authored-by: Rajat Singhal <rajatsinghal564@gmail.com>
Re-gen mavlink headers.
Improve FAQ on getting VS 2019 to work with Unreal.
Co-authored-by: David Anthony <david.anthony@swri.org>
* add azure doc to index

* initial move from external repo to airsim

* updated doc to new repo

* fixed paths for new repo and .vscode info

* added missing .vscode dir

* fixed link

* wording

* message after starting

* feedback
Changed url for the deployment
@rajat2004
Copy link
Contributor Author

Branch got messed up, closing in favour of #2861

@rajat2004 rajat2004 closed this Jul 18, 2020
@rajat2004 rajat2004 deleted the multi-vehicle-recording branch July 18, 2020 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants