-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend Recording to multiple vehicles #2847
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a34c6bd
to
df1ab03
Compare
* Reduced warning level in Unity build * Pr/2672 (#1) * [Unity] Reduce build warnings Change -Weverything to -Wextra * [Travis] Simplify Unity build command * [Unity] Fix missing override warnings Co-authored-by: Rajat Singhal <rajatsinghal564@gmail.com>
Re-gen mavlink headers. Improve FAQ on getting VS 2019 to work with Unreal.
Co-authored-by: David Anthony <david.anthony@swri.org>
* add azure doc to index * initial move from external repo to airsim * updated doc to new repo * fixed paths for new repo and .vscode info * added missing .vscode dir * fixed link * wording * message after starting * feedback
Changed url for the deployment
4 tasks
Branch got messed up, closing in favour of #2861 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Additions -
VehicleName
),VehicleName
parameter inCameras
field to specify specfic vehcile to use the camera fromFolder
field in settings to change the directory to store data inExample settings -
Recording - 2020-07-11-11-48-51.zip
Testing -
TODO:
Further possible additions -
Documents
)- I suspect this might be a race condition for the first write, since there are no images, no rendering and saving of images is required, so writing of pose data is happening almost instantaneously, but the file to write the data in hasn't still been created.(Haven't confirmed this though, just a thought)
Any testing (especially of
Folder
on Windows) or suggestions would be great!Came to mind when working on #2841
Related older issue #1346, Also includes the fix proposed in #1414