Implement JsonView support #943
Conversation
Complementary to micronaut-projects/micronaut-core#11189 .
serde-support/src/main/java/io/micronaut/serde/support/util/ViewUtil.java
Outdated
Show resolved
Hide resolved
| @@ -128,8 +128,9 @@ private JacksonJsonMapper(@NonNull SerdeRegistry registry, | |||
| @NonNull | |||
| @Override | |||
| public JsonMapper createSpecific(@NonNull Argument<?> type) { | |||
| JacksonJsonMapper mapper; | |||
There was a problem hiding this comment.
It looks to me that having the view in the mapper is useless.
I think it should be extracted in ObjectDeserializer/ObjectSerializer and create a new serializer /deserializer wrapper that will create a new context with something like context = context.withViews(...)
but that will not add a view for custom serdes so I don't know.
There was a problem hiding this comment.
i think it is sensible that the view is in the encoder context. i dont think a serializer wrapper is the right place to modify the context depending on view, the fact that we change the context view based on the argument is very specific to the JsonMappers so that is where it should stay. If we included this extractView logic inside a serializer, we risk using the JsonView of a property to modify the encoder context, which is not what a JsonView on a property is supposed to do (it is supposed to modify the visibility of the property, not change the view for child properties). And of course there is the technical issue that we'd need to change this for every createSpecific implementation unless we start wrapping literally every serde.
serde-api/src/main/java/io/micronaut/serde/config/DefaultSerdeConfiguration.java
Outdated
Show resolved
Hide resolved
serde-support/src/main/java/io/micronaut/serde/support/util/ViewUtil.java
Outdated
Show resolved
Hide resolved
| @@ -128,7 +128,7 @@ default ConversionService getConversionService() { | |||
| * @return {@code true} iff any of the given views is enabled. | |||
| */ | |||
| default boolean hasView(Class<?>... views) { | |||
| return false; | |||
| return true; | |||
There was a problem hiding this comment.
why was this default changed to true?
There was a problem hiding this comment.
Jackson databind behavior is that if no view is specified, all fields are included.
| @@ -108,7 +108,7 @@ default ConversionService getConversionService() { | |||
| * @return {@code true} iff any of the given views is enabled. | |||
| */ | |||
| default boolean hasView(Class<?>... views) { | |||
| return false; | |||
| return true; | |||
There was a problem hiding this comment.
why was this default changed to true?
|
This PR replaces most of the netty-based HTTP client that previously used the low-level micronaut-http-client ConnectionManager API with an implementation based on the new micronaut-http-client-core RawHttpClient introduced in micronaut-core 4.7.0. This offers some advantages: - Much simpler implementation. Once the legacy implementation is not needed anymore, all classes deprecated in this PR can be removed. - Possibility to work with non-netty RawHttpClient implementations, once those exist. In particular, this will allow using the JDK http client instead. - RawHttpClient runs normal micronaut-core ClientFilters, so we won't need the `OciNettyClientFilter` API anymore. While in theory the new implementation should be a drop-in replacement, it is possible that RawHttpClient differs slightly in behavior. For that reason, I've kept the old implementation around. It can be enabled by the `oci.netty.legacy-netty-client` config property, or the `io.micronaut.oraclecloud.httpclient.netty.legacy-netty-client` system property. This also means that MicronautHttpRequest and MicronautHttpResponse are actually mostly copied from NettyHttpRequest and NettyHttpResponse. Please consider that when reviewing, the actual changes are not that big. This PR works and is ready for review, but still needs a release of micronaut-core 4.7.0 (and of micronaut-serialization due to the unrelated micronaut-projects/micronaut-serialization#943 ).
* Implement netty client using the new micronaut-core RawHttpClient This PR replaces most of the netty-based HTTP client that previously used the low-level micronaut-http-client ConnectionManager API with an implementation based on the new micronaut-http-client-core RawHttpClient introduced in micronaut-core 4.7.0. This offers some advantages: - Much simpler implementation. Once the legacy implementation is not needed anymore, all classes deprecated in this PR can be removed. - Possibility to work with non-netty RawHttpClient implementations, once those exist. In particular, this will allow using the JDK http client instead. - RawHttpClient runs normal micronaut-core ClientFilters, so we won't need the `OciNettyClientFilter` API anymore. While in theory the new implementation should be a drop-in replacement, it is possible that RawHttpClient differs slightly in behavior. For that reason, I've kept the old implementation around. It can be enabled by the `oci.netty.legacy-netty-client` config property, or the `io.micronaut.oraclecloud.httpclient.netty.legacy-netty-client` system property. This also means that MicronautHttpRequest and MicronautHttpResponse are actually mostly copied from NettyHttpRequest and NettyHttpResponse. Please consider that when reviewing, the actual changes are not that big. This PR works and is ready for review, but still needs a release of micronaut-core 4.7.0 (and of micronaut-serialization due to the unrelated micronaut-projects/micronaut-serialization#943 ). * review * small changes * fix test * try fixing test * trigger build --------- Co-authored-by: Sergio del Amo <sergio.delamo@softamo.com>
Complementary to micronaut-projects/micronaut-core#11189 .