Remove JsonView filter #11189
Merged
Remove JsonView filter #11189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yawkat
approved these changes
Sep 16, 2024
|
@sdelamo Is there something wrong with the test I wrote? It looks like the configuration is not applied for GraalVM |
|
maybe the metadata is lost when running without reflection? |
|
Looks like Jackson needs reflective metadata to read the view annotation |
graemerocher
approved these changes
Sep 17, 2024
sdelamo
reviewed
Sep 18, 2024
| @@ -64,13 +65,24 @@ public JsonMediaTypeCodec(ObjectMapper objectMapper, | |||
| * @param applicationConfiguration The common application configurations | |||
| * @param codecConfiguration The configuration for the codec | |||
| */ | |||
| @Inject | |||
| public JsonMediaTypeCodec(BeanProvider<ObjectMapper> objectMapper, | |||
There was a problem hiding this comment.
can we deprecate this constructor?
| @@ -75,7 +76,6 @@ public JsonStreamMediaTypeCodec(ObjectMapper objectMapper, | |||
| * @param applicationConfiguration The common application configurations | |||
| * @param codecConfiguration The configuration for the codec | |||
| */ | |||
| @Inject | |||
There was a problem hiding this comment.
can we deprecate this constructor?
jackson-databind/src/main/java/io/micronaut/jackson/databind/JacksonDatabindMapper.java
Show resolved
Hide resolved
jackson-databind/src/main/java/io/micronaut/jackson/databind/JacksonDatabindMapper.java
Show resolved
Hide resolved
sdelamo
requested changes
Sep 18, 2024
...server-netty/src/main/java/io/micronaut/http/server/netty/jackson/JsonViewCodecResolver.java
Show resolved
Hide resolved
...etty/src/main/java/io/micronaut/http/server/netty/jackson/JsonViewMediaTypeCodecFactory.java
Show resolved
Hide resolved
|
graemerocher
approved these changes
Sep 18, 2024
| @Requires(property = JsonViewServerFilter.PROPERTY_JSON_VIEW_ENABLED) | ||
| @ServerFilter("/**") | ||
| @Internal | ||
| public class JsonViewServerFilter implements Ordered { |
There was a problem hiding this comment.
strictly speaking we have to leave this in place and deprecate it
There was a problem hiding this comment.
Why? It's internal.
There was a problem hiding this comment.
oh in that case no problem :)
yawkat
added a commit
to micronaut-projects/micronaut-serialization
that referenced
this pull request
Oct 8, 2024
Complementary to micronaut-projects/micronaut-core#11189 .
yawkat
added a commit
to micronaut-projects/micronaut-serialization
that referenced
this pull request
Oct 8, 2024
* Implement JsonView support Complementary to micronaut-projects/micronaut-core#11189 . * review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how JsonView used to work before. Instead of detecting the
JsonViewannotation using the filter and invoking serialization, the responsibility is moved to theJsonMapper. This requires the method annotation to be correctly propagated to the serializer; we need to copy the method annotations if the argument is unwrapped. Jax-RS also expects that.The property to enable the view is
jackson.json-view.enabled, but that also worked for Serde, so we need to fix it before the next minor release.