Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sonar errors, add more tests #1492

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Fix sonar errors, add more tests #1492

merged 1 commit into from
Mar 28, 2024

Conversation

altro3
Copy link
Collaborator

@altro3 altro3 commented Mar 21, 2024 •
edited
Loading

Move commons strings to constants.
Remove unused code.
Improve test coverage

@altro3 altro3 mentioned this pull request Mar 21, 2024
Closed
@altro3 altro3 requested a review from sdelamo March 21, 2024 10:55
@altro3 altro3 force-pushed the sonar2 branch 2 times, most recently from 5ca5093 to fba8fe1 Compare March 24, 2024 05:37
@altro3 altro3 changed the title Fix sonar errors Fix sonar errors, add more tests Mar 24, 2024
@altro3 altro3 force-pushed the sonar2 branch 2 times, most recently from 197e2c0 to f80c0eb Compare March 24, 2024 07:53
@altro3
Fix sonar errors.
7067082 
Add more tests.
Move commons strings to constants
@sdelamo sdelamo merged commit b172751 into micronaut-projects:master Mar 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdelamo sdelamo sdelamo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@altro3 @sdelamo