Update HelloController.kt

[adrianofsp]

fix missing annotation parameter name identifier.

[CLAassistant]

All committers have signed the CLA.

[altro3]

With KSP it is work fine. It's strange why the library works correctly and the compiler doesn't complain....

But I think this solution will be better:

BEFORE:

    @Get(uri = "/greetings/{name}", produces = [MediaType.TEXT_PLAIN])
    @Operation(summary = "Greets a person", description = "A friendly greeting is returned")
    // Please Note: Repeatable Annotations with non-SOURCE retentions are not yet supported with Kotlin, so we are using `@ApiResponses`
    // instead of `@ApiResponse`, see https://youtrack.jetbrains.com/issue/KT-12794
    @ApiResponses(
            ApiResponse(content = [Content(mediaType = "text/plain", schema = Schema(type = "string"))]),
            ApiResponse(responseCode = "400", description = "Invalid Name Supplied"),
            ApiResponse(responseCode = "404", description = "Person not found")
    )
    @Tag(name = "greeting")
    open fun greetings(name: String): Mono<String> {
        return Mono.just("Hello $name, how are you doing?")
    }

AFTER:

    @Tag(name = "greeting")
    @Operation(summary = "Greets a person", description = "A friendly greeting is returned")
    @ApiResponse(content = [Content(mediaType = "text/plain", schema = Schema(type = "string"))])
    @ApiResponse(responseCode = "400", description = "Invalid Name Supplied")
    @ApiResponse(responseCode = "404", description = "Person not found")
    @Get(uri = "/greetings/{name}", produces = [MediaType.TEXT_PLAIN])
    open fun greetings(name: String): Mono<String> {
        return Mono.just("Hello $name, how are you doing?")
    }

Need to remove comment about https://youtrack.jetbrains.com/issue/KT-12794 - it's already fixed

@adrianofsp WDYT?

[adrianofsp]

Hi, It’s true the compiler does not complain and it works. I forgot to include one dependency on the build. Thanks El El jue, 21 mar 2024 a las 5:54, altro3 ***@***.***> escribió:

…

With KSP it is work fine. It's strange why the library works correctly and the compiler doesn't complain.... default.png (view on web) <https://github.com/micronaut-projects/micronaut-openapi/assets/48474279/04acb9e5-523c-46c0-aad4-7e0e84a34ea2> default.png (view on web) <https://github.com/micronaut-projects/micronaut-openapi/assets/48474279/dc81e26b-cfcd-4261-9a0f-ca5971f79ab7> But I think this solution will be better: BEFORE: @get(uri = "/greetings/{name}", produces = [MediaType.TEXT_PLAIN]) @operation(summary = "Greets a person", description = "A friendly greeting is returned") // Please Note: Repeatable Annotations with non-SOURCE retentions are not yet supported with Kotlin, so we are using ***@***.***` // instead of ***@***.***`, see https://youtrack.jetbrains.com/issue/KT-12794 @ApiResponses( ApiResponse(content = [Content(mediaType = "text/plain", schema = Schema(type = "string"))]), ApiResponse(responseCode = "400", description = "Invalid Name Supplied"), ApiResponse(responseCode = "404", description = "Person not found") ) @tag(name = "greeting") open fun greetings(name: String): Mono<String> { return Mono.just("Hello $name, how are you doing?") } AFTER: @tag(name = "greeting") @operation(summary = "Greets a person", description = "A friendly greeting is returned") @ApiResponse(content = [Content(mediaType = "text/plain", schema = Schema(type = "string"))]) @ApiResponse(responseCode = "400", description = "Invalid Name Supplied") @ApiResponse(responseCode = "404", description = "Person not found") @get(uri = "/greetings/{name}", produces = [MediaType.TEXT_PLAIN]) open fun greetings(name: String): Mono<String> { return Mono.just("Hello $name, how are you doing?") } Need to remove comment about https://youtrack.jetbrains.com/issue/KT-12794 - it's already fixed @adrianofsp <https://github.com/adrianofsp> WDYT? — Reply to this email directly, view it on GitHub <#1491 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAK42DUE4S7Z6HVU4WGHKVDYZJRWZAVCNFSM6AAAAABFAQRGQ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJRGIYTMNJSG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[altro3]

Ok, I fixed this example here #1492