isodatetime: fix recurring recurrence format 1 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Will merge in as its a priority. Could you look to add something to the isodatetime tests that will test the affected behaviour. |
|
Tests issue raised as #26 |
arjclark
added a commit
that referenced
this pull request
Feb 28, 2014
isodatetime: fix recurring recurrence format 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug from pull request #23, which causes an infinite loop
for recurrence format 1. The get_is_valid call calls self.iter which
calls get_next again.
This fixes the bug.
@arjclark, please review.