Test for membership in TimeRecurrence #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -301,10 +320,10 @@ def get_is_in_weeks(self): | |||
| def to_days(self): | |||
| """Convert to day representation rather than weeks.""" | |||
| if self.get_is_in_weeks(): | |||
| for attribute in [self.years, self.months, self.hours, | |||
There was a problem hiding this comment.
Fix a pre-existing bug
|
Looks OK to me, nothing visibly wrong. Test battery passes. |
arjclark
added a commit
that referenced
this pull request
Feb 27, 2014
Test for membership in TimeRecurrence
This was referenced Feb 28, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is useful to check whether a given
TimePointisa member of the series of a
TimeRecurrence.This is useful for @hjoliver's work on cylc/cylc-flow#887.
This adds that functionality and adds more tests for
the adding and subtracting API for TimePoint, fixing
some bugs as found by the new tests.
@arjclark, please review.