-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wildcard name matching #85
Fix wildcard name matching #85
Conversation
… matching of node names in metapath queries. Prior changes adjusted the behavior of wildcard processing, but this code was not fully intgrated everywhere. These changes complete implementing the new wildcard matching behavior.
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
thanks for the quick fix!
50fe576
into
metaschema-framework:release/1.0
Committer Notes
This PR fixes a bug which affects GSA/fedramp-automation#622. The bug is caused by improper matching of node names in Metapath queries. Prior changes adjusted the behavior of wildcard processing, but this code was not fully used everywhere. These changes complete implementing the new wildcard matching behavior to correct this bug.
This PR also fixes use of some deprecated APIs and improves the handling of constraint errors to improve debugging.
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
Changes to Core Features: