Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New fixes #166

Merged
merged 24 commits into from
Oct 29, 2023
Merged

New fixes #166

merged 24 commits into from
Oct 29, 2023

Conversation

Rashmi-278
Copy link
Member

@Rashmi-278 Rashmi-278 commented Oct 27, 2023

Summary

  • Adds managerAddress and contractsRegistryURI to Indexer and Frontend
  • New and Old Registrations compatible with <Gateway>/<CID> format
  • Hide Spam and Test DAOs
  • Add Contract Address field filter in Registration Form for Custom Framework

Fixes issues:
#134
#126

This PR includes the following changes

  • Update state variables to include managerAddress and contractsRegistryURI
  • Update queries
  • Update DAOstar API Repo
  • Deploy DAOstar API Repo
  • Update GraphQL Mapping for current and old contracts to include new fields and get CID for daoURI from last character
  • Deploy graphQL to all networks after the changes are live on DAOstar API
  • Update all network query URIs
  • Test OK

Network Checklist:

  • Mainnet
  • Optimism
  • Goerli
  • Optimism-Goerli
  • Arbitrum-Goerli
  • BNB Bruno (Chapel)

@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for whimsical-cuchufli-3a5565 ready!

Name Link
🔨 Latest commit 6a2b03e
🔍 Latest deploy log https://app.netlify.com/sites/whimsical-cuchufli-3a5565/deploys/653ee8317c05940008c999b9
😎 Deploy Preview https://deploy-preview-166--whimsical-cuchufli-3a5565.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member Author

@Rashmi-278 Rashmi-278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three changes suggested, fix the typo

Copy link
Member Author

@Rashmi-278 Rashmi-278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self Approved

Copy link
Member Author

@Rashmi-278 Rashmi-278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self Approved

@Rashmi-278 Rashmi-278 merged commit f4ea43f into metagov:main Oct 29, 2023
3 checks passed
@Rashmi-278 Rashmi-278 self-assigned this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant