Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAO URI doesn't accept managerAddress and contractRegistryURI #134

Closed
Rashmi-278 opened this issue Aug 30, 2023 · 6 comments
Closed

DAO URI doesn't accept managerAddress and contractRegistryURI #134

Rashmi-278 opened this issue Aug 30, 2023 · 6 comments
Assignees

Comments

@Rashmi-278
Copy link
Member

Rashmi-278 commented Aug 30, 2023

This was because the graphQL schema and API validation schema did not include these fields.
PR: #135

@Rashmi-278
Copy link
Member Author

Adding this would conflict with the current DAO-IP2 Standard, perhaps more discussion is needed on which fields should be included in the DAO URI.

@Rashmi-278
Copy link
Member Author

Should the standard include managerAddress?
https://eips.ethereum.org/EIPS/eip-4824

@thelastjosh
Copy link
Member

thelastjosh commented Sep 20, 2023 via email

@Rashmi-278
Copy link
Member Author

Sorry! My bad, I meant in the DAO URI schema
image

@Rashmi-278
Copy link
Member Author

The graph error on my end is resolved, build succeeds
Blockers

  • DAO* API deployed on Digital Ocean Droplet needs to be reloaded to reflect the changes
  • After the above step, we need to deploy the graph instances for all the networks once again

@Rashmi-278 Rashmi-278 mentioned this issue Oct 29, 2023
14 tasks
@Rashmi-278
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants